Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]add test case for [linkis-scheduler] #1914 #2205

Merged
merged 3 commits into from
Jun 5, 2022
Merged

[WIP]add test case for [linkis-scheduler] #1914 #2205

merged 3 commits into from
Jun 5, 2022

Conversation

QuintinTao
Copy link
Contributor

@QuintinTao QuintinTao commented Jun 1, 2022

What is the purpose of the change

Added tests for linkis-scheduler package

@peacewong
Copy link
Contributor

Thanks, I will review this

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2205 (a60ff18) into dev-1.1.3 (d57abbc) will increase coverage by 0.96%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.1.3    #2205      +/-   ##
===============================================
+ Coverage        19.13%   20.09%   +0.96%     
- Complexity         843     1001     +158     
===============================================
  Files              387      425      +38     
  Lines            12120    12926     +806     
  Branches          1816     2035     +219     
===============================================
+ Hits              2319     2598     +279     
- Misses            9558     9992     +434     
- Partials           243      336      +93     
Impacted Files Coverage Δ
.../scala/org/apache/linkis/scheduler/Scheduler.scala 0.00% <0.00%> (ø)
...la/org/apache/linkis/scheduler/queue/JobInfo.scala 0.00% <0.00%> (ø)
...pache/linkis/scheduler/executer/ExecutorInfo.scala 0.00% <0.00%> (ø)
...nkis/scheduler/queue/fifoqueue/FIFOScheduler.scala 100.00% <0.00%> (ø)
...pache/linkis/scheduler/queue/ConsumerManager.scala 100.00% <0.00%> (ø)
...er/exception/WaitForNextAskExecutorException.scala 100.00% <0.00%> (ø)
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 34.44% <0.00%> (ø)
...eduler/queue/parallelqueue/ParallelScheduler.scala 85.71% <0.00%> (ø)
...ler/queue/parallelqueue/ParallelGroupFactory.scala 66.66% <0.00%> (ø)
...apache/linkis/scheduler/queue/SchedulerEvent.scala 50.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57abbc...a60ff18. Read the comment docs.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 32aac24 into apache:dev-1.1.3 Jun 5, 2022
@peacewong
Copy link
Contributor

Hello, the username in your commit may be inconsistent with GitHub, so that it will not be counted as contributor, and you need to reset it.

@QuintinTao
Copy link
Contributor Author

me in your commit may be inconsistent with GitHub, so that it will not be counted as contributor, and

OK I will correct it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants