Fix bug about PR #950, Related issues: #946. #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P,the value of env will read from ecm host by key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: engine can't get env EUREKA_PREFER_IP.
Fix : add ENGINECONN_ENVKEYS into ecm engine Environment，so it will add custom env，such as EUREKA_PREFER_IP
if you want Transfer env EUREKA_PREFER_IP to engine ,set "wds.linkis.engineconn.env.keys=EUREKA_PREFER_IP" in linkis-cg-engineconnmanager.properties . you can add other custome envs, separate by “，”。
What is the purpose of the change
Related issues: #590.
Brief change log
Define EUREKA_PREFER_IP in Environment.scala
set EUREKA_PREFER_IP value in ProcessEngineConnLaunch.scala
Verifying this change
This change added tests and can be verified as follows:
set "wds.linkis.engineconn.env.keys=EUREKA_PREFER_IP" in linkis-cg-engineconnmanager.properties， then start all service.
through scripts or resful interface to call job excute. if the job success finish,it will be ok.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): no)
Anything that affects deployment: ( no )
The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: ( no)
Documentation
Does this pull request introduce a new feature? no)
If yes, how is the feature documented? (not applicable )