Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use isBlank judge partition #1022

Merged
merged 1 commit into from
Oct 11, 2021
Merged

use isBlank judge partition #1022

merged 1 commit into from
Oct 11, 2021

Conversation

Shlpeng
Copy link
Contributor

@Shlpeng Shlpeng commented Sep 29, 2021

judge partition is empty by StringUtils.isBlank

What is the purpose of the change

(For example: EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection and session management.
Related issues: #590. )

Brief change log

(for example:)

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

  • Added tests for submit and execute all kinds of jobs to go through and verify the lifecycles of different EngineConns.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • Anything that affects deployment: (yes / no / don't know)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

judge partition is empty by StringUtils.isBlank
@peacewong peacewong changed the base branch from master to dev-1.0.3 October 11, 2021 07:32
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit badef8c into apache:dev-1.0.3 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants