Fix a regression with "get_driver()" function not working with string values #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"provider" value is a string and not an enum. In reality, "provider" value should really be a Provider ENUM constant type, but previous versions supported strings as well so it makes sense to still support that notation until a future major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression which was inadvertently introduced in #1306 as part of MyPy refactoring changes.
That change broke
get_driver()method so it doesn't work anymore ifproviderargument is a string and not anProvider.FOOenum type.Only officially supported and recommended approach still is to use
Provider.FOOenum constants, but since string notation was supported in the past and likely a lot of the existing code relies on it, we should still support (at least until we have the time to properly officially deprecate and remove support for it).Resolves #1390.