Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor the implementation of the command ZRANDMEMBER #2025

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Minor refactor the implementation of the command ZRANDMEMBER #2025

merged 2 commits into from
Jan 17, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jan 16, 2024

  1. Using std::mt19937 rather than std::random_device for performance
  2. Fix NotFound for meta
  3. Using std::move if possible

@mapleFU mapleFU mentioned this pull request Jan 16, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk changed the title Cleanup ZRANDMEMBER implemention Minor refactor the implementation of the command ZRANDMEMBER Jan 17, 2024
@git-hulk git-hulk merged commit d9acbba into apache:unstable Jan 17, 2024
29 checks passed
@mapleFU mapleFU deleted the cleanup-zset-random branch January 17, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleFU @git-hulk @torwig