Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to fetch old value in SET command if NX/XX/GET/KEEPTTL is not set #1968

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Avoid to fetch old value in SET command if NX/XX/GET/KEEPTTL is not set #1968

merged 2 commits into from
Dec 25, 2023

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 24, 2023 •
edited
Loading

I found this issue while implementing the keyspace hit/miss information. We don't need to get the old value if none of NX/XX/GET/KEEPTTL is set.

This bug was introduced in #1935

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 24, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk merged commit 3d83f2e into apache:unstable Dec 25, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@git-hulk @torwig