Add redis_mode/kvrocks_mode fields in INFO SERVER #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we will already show cluster_enabled in INFO CLUSTER, some tools such as redis manger will need this field to determine whether it is cluster mode. If cluster mode is enabled, redis_mode is displayed as cluster, otherwise it is standalone. Fixes apache#1926.
|
should we use this opportunity to add a kvrocks_mode? |
I think so. |
enjoy-binbin
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
git-hulk
approved these changes
Dec 8, 2023
enjoy-binbin
changed the title
git-hulk
pushed a commit
that referenced
this pull request
Dec 8, 2023
Although we will already show cluster_enabled in INFO CLUSTER, some tools such as Redis Manager will need this field to determine whether it is cluster mode. If cluster mode is enabled, redis_mode is displayed as a cluster, otherwise, it is standalone. We also use this opportunity to add a kvrocks_mode field. Fixes #1926.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we will already show cluster_enabled in INFO CLUSTER,
some tools such as redis manger will need this field to determine
whether it is cluster mode.
If cluster mode is enabled, redis_mode is displayed as cluster,
otherwise it is standalone. We also use this opportunity to add
a kvrocks_mode field.
Fixes #1926.