Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of rocksdb's write delay and stop stats in INFO command #1916

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Fix name of rocksdb's write delay and stop stats in INFO command #1916

merged 2 commits into from
Dec 3, 2023

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 3, 2023 •
edited
Loading

This closes #1913

rocksdb rename the write stall stats of the DB and column family in rocksdb #11300,
which organizes them more structurally. So it will return an empty string in the INFO command
since we're still using the old stat key to fetch them.

The INFO command will return "0" instead of the empty string after this patch:

level0_file_limit_slowdown[metadata]:0
level0_file_limit_stop[metadata]:0
pending_compaction_bytes_slowdown[metadata]:0
pending_compaction_bytes_stop[metadata]:0
level0_file_limit_stop_with_ongoing_compaction[metadata]:0
level0_file_limit_slowdown_with_ongoing_compaction[metadata]:0
memtable_count_limit_slowdown[metadata]:0
memtable_count_limit_stop[metadata]:0

and the current output is:

level0_file_limit_slowdown[default]:
level0_file_limit_stop[default]:
pending_compaction_bytes_slowdown[default]:
pending_compaction_bytes_stop[default]:
memtable_count_limit_slowdown[default]:
memtable_count_limit_stop[default]:

@git-hulk
Fix name of rocksdb's write delay and stop stats in INFO command
7803047 
rocksdb rename the write stall stats of the db and column family in
rocksdb #11300, which organizes them in a more strcutural way. So it
will return an empty string in INFO command since we're still use the
old stat key to fetch them.
@git-hulk
Merge branch 'unstable' into fix/1913
4e6ba21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@git-hulk git-hulk merged commit 55d21dd into apache:unstable Dec 3, 2023
30 checks passed
@enjoy-binbin
Copy link
Member

How did we lose this change when upgrading rocksdb? It seems like a good opportunity to think about how to handle the upgrade of dependency more safely.

@git-hulk
Copy link
Member Author

git-hulk commented Dec 4, 2023 •
edited
Loading

How did we lose this change when upgrading rocksdb? It seems like a good opportunity to think about how to handle the upgrade of dependency more safely.

Yes, we now don't have enough cases to confirm whether it's good to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@torwig torwig torwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

output for 'level0_file_limit_stop' from ino is empty
4 participants
@git-hulk @enjoy-binbin @torwig @PragmaTwice