Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clear unused vector #1915

Merged
merged 1 commit into from
Dec 3, 2023
Merged

chore: clear unused vector #1915

merged 1 commit into from
Dec 3, 2023

Conversation

kay011
Copy link
Contributor

@kay011 kay011 commented Dec 3, 2023

this vector is unused in function, but it was not intercepted in compiling stage

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

PragmaTwice
PragmaTwice approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @git-hulk

tisonkun
tisonkun approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun changed the title Clear unused vector chore: clear unused vector Dec 3, 2023
@git-hulk
Copy link
Member

git-hulk commented Dec 3, 2023

Good catch, it's an unused code.

@git-hulk git-hulk merged commit efc720d into apache:unstable Dec 3, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@tisonkun tisonkun tisonkun approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kay011 @git-hulk @tisonkun @PragmaTwice @KarateYuan