Support for the JSON.ARRPOP command #1874
Conversation
src/types/json.h
Outdated
| auto popped_iter = val.array_range().begin(); | ||
| if (index == -1 || index >= static_cast<int64_t>(val.size())) { | ||
| popped_iter = val.array_range().end() - 1; | ||
| } else if (index > 0) { | ||
| popped_iter += index; | ||
| } |
There was a problem hiding this comment.
I think if the index is negative, we need to calculate the real position from the end.
127.0.0.1:6666> json.set a $ [1,2,3,4]
OK
127.0.0.1:6666> json.arrpop a $ -2
1) "3"
127.0.0.1:6666>I recommend you to try it by yourself : )
There was a problem hiding this comment.
I'm sorry I misunderstood Out-of-range indexes round to their respective array ends stated in the doc.
I've fixed it based on the below code in RedisJson.
impl ArrayIndex for i64 {
fn normalize(self, len: i64) -> usize {
let index = if self < 0 {
len - len.min(-self)
} else if len > 0 {
(len - 1).min(self)
} else {
0
};
index as usize
}
}
|
Could you try to fix these issue reported by clang-tidy in CI? https://github.com/apache/kvrocks/actions/runs/6754872818/job/18363385655?pr=1874 |
Fixed. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you for your contribution! |
This PR adds support for the JSON.ARRPOP command.
closes #1810.