Fix ZMPOP/BZMPOP duplicate parameters #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not check for repeated parameters before, so the following code is executable: ``` 127.0.0.1:6666> zmpop 1 zset min max (nil) 127.0.0.1:6666> zmpop 1 zset min count 10 count 100 (nil) 127.0.0.1:6666> zmpop 1 zset min min max max min (nil) 127.0.0.1:6666> zmpop 1 zset min count 10 count 100 max (nil) 127.0.0.1:6666> bzmpop 0.1 1 zset min max (nil) 127.0.0.1:6666> bzmpop 0.1 1 zset min count 1 count 10 (nil) ``` Now we don't allow duplicate parameters (throw a syntax error): ``` 127.0.0.1:6666> zmpop 1 zset min max (error) ERR syntax error 127.0.0.1:6666> zmpop 1 zset min count 10 count 100 (error) ERR syntax error 127.0.0.1:6666> zmpop 1 zset min min max max min (error) ERR syntax error 127.0.0.1:6666> zmpop 1 zset min count 10 count 100 max (error) ERR syntax error 127.0.0.1:6666> bzmpop 0.1 1 zset min max (error) ERR syntax error 127.0.0.1:6666> bzmpop 0.1 1 zset min count 1 count 10 (error) ERR syntax error ``` Also added some tests to cover these wrong error paths. Refs: ZMPOP was added in apache#1468 and BZMPOP was added in apache#1490.
|
This may not be that important, since there may be other commands that have this problem (redis itself also have it), |
git-hulk
previously approved these changes
Jul 5, 2023
git-hulk
approved these changes
Jul 5, 2023
PragmaTwice
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not check for repeated parameters before, so the
following code is executable:
Now we don't allow duplicate parameters (throw a syntax error):
Also added some tests to cover these wrong error paths.
Refs: ZMPOP was added in #1468 and BZMPOP was added in #1490.