Fix redundant newline in eval error compiling message #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-cli
return the invalid protocol error message:Bad simple string value
, when compiling the Lua script with an error:And what we want is to return the compiling error like below:
The root cause is Kvrocks adds a redundant newline when returning the compiling error, and
redis-cli
would regard it as an invalid protocol since any newline in the simple string was forbidden: https://github.com/redis/hiredis/blob/04c1b5b0292da1c6515baf6cb5b5b9bb882f38d7/read.c#L370