Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round expire time for seconds to improve precision for 32bit-common-field encoding #1352

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Round expire time for seconds to improve precision for 32bit-common-field encoding #1352

merged 2 commits into from
Mar 24, 2023

Conversation

PragmaTwice
Copy link
Member

We use (ms + 499) / 1000 instead of ms / 1000 to round numbers for better precision.

@PragmaTwice PragmaTwice merged commit 95301c5 into apache:unstable Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @git-hulk