Allow to configure the compaction checker policy #1325
Conversation
git-hulk
changed the title
|
@ellutionist can you help to resolve conflicts? |
ellutionist
force-pushed
the
force_compact_policy
branch
from
7e06f1a
to
ac4cf91
Compare
| << " finished, result: " << s.ToString(); | ||
| maxFilesToCompact--; | ||
| continue; |
There was a problem hiding this comment.
@git-hulk @PragmaTwice @xiaobiaozhao I kindly ask you to pay attention to this new continue sentence because this will actually change how the compaction_checker works.
I add this because if a SST file has been compacted due to the "force compact policy", it should not be considered as a possible candidate with the best_delete_ratio. If it is not so skipped, the file may be compacted twice in a single call of PickCompactionFiles, from my point of view.
If any of you think this change is not proper please let me know.
There was a problem hiding this comment.
@ellutionist Thanks for your point out. You're right that is unnecessary to check again.
|
Thanks all, merging... |
|
Thanks for @ellutionist contribution again. |
This PR close #1291 .