Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-16803: Update ShadowJavaPlugin #16295

Merged
merged 2 commits into from
Jun 20, 2024
Merged

KAFKA-16803: Update ShadowJavaPlugin #16295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d981d
Replace Plugin johnrengelman.shadow to goooler.shadow in build.gradle
Nancy-ksolves Jun 11, 2024
82a0012
Comment Removed
Nancy-ksolves Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ plugins {
// be dropped from gradle/resources/dependencycheck-suppressions.xml
id "com.github.spotbugs" version '5.1.3' apply false
id 'org.scoverage' version '8.0.3' apply false
// Updating the shadow plugin version to 8.1.1 causes issue with signing and publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
id 'io.github.goooler.shadow' version '8.1.7' apply false
// Spotless 6.13.0 has issue with Java 21 (see https://github.com/diffplug/spotless/pull/1920), and Spotless 6.14.0+ requires JRE 11
// We are going to drop JDK8 support. Hence, the spotless is upgrade to newest version and be applied only if the build env is compatible with JDK 11.
// spotless 6.15.0+ has issue in runtime with JDK8 even through we define it with `apply:false`. see https://github.com/diffplug/spotless/issues/2156 for more details
Expand Down Expand Up @@ -388,7 +386,7 @@ subprojects {
if (!shouldPublishWithShadow) {
from components.java
} else {
apply plugin: 'com.github.johnrengelman.shadow'
apply plugin: 'io.github.goooler.shadow'
project.shadow.component(mavenJava)

// Fix for avoiding inclusion of runtime dependencies marked as 'shadow' in MANIFEST Class-Path.
Expand Down Expand Up @@ -2985,7 +2983,7 @@ project(':streams:upgrade-system-tests-37') {

project(':jmh-benchmarks') {

apply plugin: 'com.github.johnrengelman.shadow'
apply plugin: 'io.github.goooler.shadow'

shadowJar {
archiveBaseName = 'kafka-jmh-benchmarks'
Expand Down