Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-13391: don't fsync directory on Windows OS #11426

Merged
merged 2 commits into from
Oct 25, 2021
Merged

KAFKA-13391: don't fsync directory on Windows OS #11426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9573bdd
KAFKA-13391: don't fsync directory on Windows OS
showuon Oct 21, 2021
6bd53f3
KAFKA-13391: address review comments ro rephrase comments
showuon Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clients/src/main/java/org/apache/kafka/common/utils/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,10 +948,12 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean need
/**
* Flushes dirty directories to guarantee crash consistency.
*
* Note: We don't fsync directories on Windows OS because otherwise it'll throw AccessDeniedException (KAFKA-13391)
*
* @throws IOException if flushing the directory fails.
*/
public static void flushDir(Path path) throws IOException {
if (path != null) {
if (path != null && !OperatingSystem.IS_WINDOWS) {
try (FileChannel dir = FileChannel.open(path, StandardOpenOption.READ)) {
dir.force(true);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a file lock on this file that causes the issue, which might be hiding another issue even on other platforms.

}
Expand Down