JCLOUDS-1497: Fix checkstyle-suppressions for jcloud-labs #27
Conversation
oflebbe
changed the title
|
Closing and re-opening to trigger the build again |
| @@ -48,7 +48,7 @@ | |||
| </module> | |||
| <module name="NoWhitespaceBefore"/> | |||
| <module name="RedundantImport"/> | |||
| <module name="RedundantModifier"/> | |||
| <!-- <module name="RedundantModifier"/> --> | |||
There was a problem hiding this comment.
The PR LGTM, but why are you removing this check?
There was a problem hiding this comment.
We have some static imports (search for "import static") in the code. I am doubting it is worth the effort to fix it. Wdyt ?
There was a problem hiding this comment.
I'm wondering why this check was not failing before. Anyway, I agree there is little value in this one.
There was a problem hiding this comment.
This check should find redundant modifiers like public in interfaces, not static imports.
There was a problem hiding this comment.
Right. I ran a local build and only in core there were more than 40 violations. I fixed them, then found the same in another project... So I agree the value this check provides is close to zero and I think removing it is OK.
There was a problem hiding this comment.
I run the report again, and yeah sorry you are right: The violations where way down the file not on top where the "import static" was used.
This is the jclouds part of fixing checkstyle. jclouds-labs has a couple of violations as well