Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11597][SDK] Optimize the generation speed of UUIDv4 #11598

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

davendu
Copy link
Contributor

@davendu davendu commented Dec 13, 2024

Fixes #11597

Motivation

Speed up UUIDv4 generation.

Modifications

  • Swap references from github.com/gofrs/uuid to github.com/google/uuid while preserve compatibility. Benchmark is listed in the original issue.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable
  • If a feature is not applicable for documentation, explain why? This is not really a feature

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @davendu, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@gunli
Copy link
Contributor

gunli commented Dec 16, 2024

LGTM

@dockerzhang dockerzhang merged commit 64b3531 into apache:master Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve]Optimize the generation speed of UUIDv4 for Golang SDK
4 participants