Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Support GitHub Action build the xtable project #462

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

daragu
Copy link
Contributor

@daragu daragu commented Jun 7, 2024

Important Read

What is the purpose of the pull request

Due to the Azure CI is always unstable, so we use Github Action to try to solve this problem.

Verify this pull request

locally.

@daragu
Copy link
Contributor Author

daragu commented Jun 7, 2024


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually add ${{ !contains(github.ref, 'main') }} on my repos so that we don't cancel builds on the main branch in case there is a failure, it makes it a bit easier to pinpoint. What are your thoughts on adding this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use the default behavior from the doc.
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-concurrency-and-the-default-behavior

And thanks for sharing how you use it, and I had update the build workflow.

.github/workflows/mvn-ci-build.yml Outdated Show resolved Hide resolved
@daragu
Copy link
Contributor Author

daragu commented Jun 8, 2024

Hi @the-other-tim-brown, do we need to disable azure ci in this pr? Or we wait github action runs smoothly for a period of time, then disable it.

@ghost
Copy link

ghost commented Jun 8, 2024

CI report:

Bot commands @xtable-bot supports the following commands:
  • @xtable-bot run azure re-run the last Azure build

@the-other-tim-brown
Copy link
Contributor

Hi @the-other-tim-brown, do we need to disable azure ci in this pr? Or we wait github action runs smoothly for a period of time, then disable it.

Let's disable it in another PR after we merge this and do a quick sanity check

@daragu
Copy link
Contributor Author

daragu commented Jun 11, 2024

Hi @the-other-tim-brown, do we need to disable azure ci in this pr? Or we wait github action runs smoothly for a period of time, then disable it.

Let's disable it in another PR after we merge this and do a quick sanity check

OK

@the-other-tim-brown the-other-tim-brown merged commit 5bc6c16 into apache:main Jun 11, 2024
3 checks passed
@charlesy6
Copy link

LGTM

@daragu daragu deleted the patch branch July 8, 2024 14:52
@vinishjail97 vinishjail97 mentioned this pull request Aug 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants