-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Support GitHub Action build the xtable project #462
Conversation
it works in myself projects. |
.github/workflows/mvn-ci-build.yml
Outdated
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually add ${{ !contains(github.ref, 'main') }}
on my repos so that we don't cancel builds on the main
branch in case there is a failure, it makes it a bit easier to pinpoint. What are your thoughts on adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually use the default behavior from the doc.
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-concurrency-and-the-default-behavior
And thanks for sharing how you use it, and I had update the build workflow.
Hi @the-other-tim-brown, do we need to disable |
Let's disable it in another PR after we merge this and do a quick sanity check |
OK |
LGTM |
Important Read
What is the purpose of the pull request
Due to the Azure CI is always unstable, so we use
Github Action
to try to solve this problem.Verify this pull request
locally.