-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] added run_syn_tool.sh with HMS example and also added more on S3 changes needed for Trino. #458
base: main
Are you sure you want to change the base?
Conversation
Update hms.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some nit comments, will merge after addressing them.
```shell md title="shell" | ||
java -jar xtable-utilities/target/xtable-utilities-0.2.0-SNAPSHOT-bundled.jar --datasetConfig my_config.yaml | ||
```shell in JDBC md title="shell in JDBC" | ||
java -jar xtable-utilities/target/xtable-utilities-0.1.0-SNAPSHOT-bundled.jar --datasetConfig my_config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We updated the version to 0.2.0-SNAPSHOT in main branch now.
I feel it's better to use the downloads from maven for the demo going forward. WDYT ?
https://xtable.apache.org/releases/downloads/
To fix #455
What is the purpose of the pull request
added run_syn_tool.sh with HMS example and also added more on S3 changes needed for Trino.
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.