[Infra] Introduce apache rat plugin to xtable project #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @the-other-tim-brown @charlesy6 @sagarlakshmipathy, take a review when free, thanks. |
charlesy6
reviewed
May 28, 2024
|
Thanks @the-other-tim-brown for the suggestion. Patch is updated accordingly, can you please take another look? |
xleoken
approved these changes
Jun 4, 2024
the-other-tim-brown
approved these changes
Jun 5, 2024
|
Thanks @daragu for setting this up for us! |
My pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
As we known,
apache-ratplugin cat verify whether source code matches standards like the ASF Source Header and Copyright Notice Policy, and this plugin is widely used in many projects, like hudi, flink ...The
spotless-maven-plugincan only check several file types, so it can't fits our need.https://creadur.apache.org/rat/apache-rat-plugin/usage.html
Verify this pull request
Manually verified the change by running a job locally.