Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android]fix slider border radius invalid problem #2658

Merged
merged 2 commits into from
Jul 8, 2019
Merged

[Android]fix slider border radius invalid problem #2658

merged 2 commits into from
Jul 8, 2019

Conversation

katherine95s
Copy link
Contributor

No description provided.

YorkShen
YorkShen suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Move getComponent and holdComponent from BaseFrameLayout to WXFrameLayout as both methods use WXDiv as return value or function parameter.
  2. Change WXFrameLayout.dispatchDraw() to following:
    try {
    super.dispatchDrawInterval(canvas);
    } catch (Throwable e) {
    //Some Code
    }

YorkShen
YorkShen approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit 32fac76 into apache:master Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YorkShen YorkShen YorkShen approved these changes

@Darin726 Darin726 Awaiting requested review from Darin726

@gubaojian gubaojian Awaiting requested review from gubaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katherine95s @YorkShen