Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2279] improvement(spark): Trigger the upstream rewrite when the read stage fails #2281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented Dec 9, 2024

What changes were proposed in this pull request?

If the current Reader fails to obtain Shuffle data, it does not trigger the upstream Stage to rewrite the data. If a Shuffle Server fails, it does not trigger Stage retry.

Why are the changes needed?

Fix: #2279

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@yl09099
Copy link
Contributor Author

yl09099 commented Dec 9, 2024

Wait a minute. I'm not ready for this.

Copy link

github-actions bot commented Dec 9, 2024

Test Results

 2 966 files  +23   2 966 suites  +23   6h 26m 34s ⏱️ + 7m 36s
 1 096 tests ± 0   1 094 ✅ + 1   2 💤 ±0  0 ❌  - 1 
13 735 runs  +53  13 705 ✅ +54  30 💤 ±0  0 ❌  - 1 

Results for commit 69f340f. ± Comparison against base commit 0552d3b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] The upstream rewrite is triggered when the read stage fails.
1 participant