[sqllab] more robust copy to clipboard #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6180 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 47 47
Lines 9362 9362
=======================================
Hits 7201 7201
Misses 2161 2161Continue to review full report at Codecov.
|
williaster
changed the title
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Oct 25, 2018
* [sqllab] implement more robust share query button * [sqllab] fix Hotkeys react warnings * [CopyToClipboard] don't bind in render functions * [explorer] fix short url button position * [sqllab] remove share query item in tab dropdown menu * [sqllab] reference new ShareSqlLabQuery component * [sqllab][share query robustness] clean up * [sqllab] fix tests * [sqllab][share query] add unit tests (cherry picked from commit 90809f6)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [sqllab] implement more robust share query button * [sqllab] fix Hotkeys react warnings * [CopyToClipboard] don't bind in render functions * [explorer] fix short url button position * [sqllab] remove share query item in tab dropdown menu * [sqllab] reference new ShareSqlLabQuery component * [sqllab][share query robustness] clean up * [sqllab] fix tests * [sqllab][share query] add unit tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
idfor a popover, no key for array-generated children)before
after
@kristw @michellethomas @graceguo-supercat @mistercrunch