Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqllab copy link is not as reliable as it can be #6140

Closed
williaster opened this issue Oct 18, 2018 · 0 comments · Fixed by #6180
Closed

Sqllab copy link is not as reliable as it can be #6140

williaster opened this issue Oct 18, 2018 · 0 comments · Fixed by #6180
Assignees
@williaster
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@williaster
Copy link
Contributor

When refactoring Sqllab to leverage SupersetClient instead of ajax, a mostly-reliable "copy sql query link" command was implemented here.

This isn't as reliable as it could be, filing this issue to ensure it's refactored to be more reliable.

cc @kristw
@williaster williaster added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 18, 2018
@williaster williaster self-assigned this Oct 18, 2018
@williaster williaster mentioned this issue Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williaster williaster

Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sqllab] more robust copy to clipboard williaster/superset
1 participant
@williaster