[SQLA] Improving performance by disabling editing Associated Charts #5136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to improve the performance of table CRUD view by removing the
slices
(Associated Charts) column from the edit view (it's still present for show). For reference for our datasource the page load time reduced from ~ 45 s to ~ 7 s.As the number of slices grows the performance of this page is severely impacted as FAB needs to pre-fetch all the slices which are searchable in jQuery. Further it seems having the ability to either add/remove slices associated with a datasource via the CRUD view is somewhat atypical as it could result in ill-defined charts and dangling charts respectively.
This significantly improves the performance when view the
Detail
,List Columns
, orList Metrics
columns. Note however the table drop-down is still susceptible to the same issue, however this field is required in order to associate a new column/metric with the datasource.to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa