Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLA] Improving performance by disabling editing Associated Charts #5136

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 5, 2018

This PR helps to improve the performance of table CRUD view by removing the slices (Associated Charts) column from the edit view (it's still present for show). For reference for our datasource the page load time reduced from ~ 45 s to ~ 7 s.

As the number of slices grows the performance of this page is severely impacted as FAB needs to pre-fetch all the slices which are searchable in jQuery. Further it seems having the ability to either add/remove slices associated with a datasource via the CRUD view is somewhat atypical as it could result in ill-defined charts and dangling charts respectively.

This significantly improves the performance when view the Detail, List Columns, or List Metrics columns. Note however the table drop-down is still susceptible to the same issue, however this field is required in order to associate a new column/metric with the datasource.

to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa

@codecov-io
Copy link

Codecov Report

Merging #5136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5136   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          44       44           
  Lines        8734     8734           
=======================================
  Hits         6770     6770           
  Misses       1964     1964
Impacted Files Coverage Δ
superset/connectors/sqla/views.py 70.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2bc4ec...7657dda. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@john-bodley john-bodley merged commit f102eab into apache:master Jun 6, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Jun 6, 2018
@john-bodley john-bodley changed the title [CRUD] Improving performance by disabling editing Associated Charts [SQLA] Improving performance by disabling editing Associated Charts Jun 18, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants