Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherry picking fixes for may merge #50

Conversation

michellethomas
Copy link

@michellethomas michellethomas commented Jun 6, 2018

@john-bodley @graceguo-supercat @timifasubaa

@michellethomas
Copy link
Author

I'll also cherry-pick John's migration when it's merged apache#5135

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #50 into airbnb-master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           airbnb-master      #50   +/-   ##
==============================================
  Coverage          77.45%   77.45%           
==============================================
  Files                 44       44           
  Lines               8672     8672           
==============================================
  Hits                6717     6717           
  Misses              1955     1955
Impacted Files Coverage Δ
superset/connectors/sqla/views.py 70.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bbdc5...f43e460. Read the comment docs.

@michellethomas michellethomas merged commit ec0e949 into airbnb:airbnb-master Jun 7, 2018
@michellethomas michellethomas deleted the mt_cherry_pick_may_merge_fixes branch June 7, 2018 19:04
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* scaffold

* resolve dependency issues

* use d3 v4

* - Update peer dependencies
- Getting src to build

* Type word cloud

* Add tests for transformProps

* Update and simplify d3-cloud typing as the fix we've been waiting was merged.

* resolve all tests

* update unit tests

* fix unit test

* update readme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants