Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to templates / respect slice timeout #4673

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Add context to templates / respect slice timeout #4673

merged 3 commits into from
Apr 5, 2018
+5 −0

Conversation

daoready
Copy link
Contributor

  1. Extended context to include filter data and columns to be able to insert WHERE in templates, based on filters
  2. Fix for Slice level cache_timeout isn't taken into consideration #4672

@mistercrunch
Copy link
Member

It would be nice if you can add cache-related unit tests to prevent future regressions like that recent one.

@daoready
Copy link
Contributor Author

I do not know Python, for me it is quite difficult to add tests, sorry about that

@codecov-io
Copy link

Codecov Report

Merging #4673 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4673      +/-   ##
==========================================
- Coverage   71.37%   71.37%   -0.01%     
==========================================
  Files         190      190              
  Lines       14918    14920       +2     
  Branches     1102     1102              
==========================================
+ Hits        10648    10649       +1     
- Misses       4267     4268       +1     
  Partials        3        3
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 77.91% <ø> (ø) ⬆️
superset/viz.py 79.57% <50%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b996523...ef95564. Read the comment docs.

@mistercrunch mistercrunch merged commit 92230b8 into apache:master Apr 5, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@daoready @michellethomas
Add context to templates / respect slice timeout (apache#4673)
8e7491d 
* added context to templates to be able to use filters in SQL

* respect slice timeout in favor of others

* added trailing comma
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
@daoready @timifasubaa
Add context to templates / respect slice timeout (apache#4673)
82c1bc3 
* added context to templates to be able to use filters in SQL

* respect slice timeout in favor of others

* added trailing comma
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@daoready @mistercrunch
Add context to templates / respect slice timeout (apache#4673)
961da3b 
* added context to templates to be able to use filters in SQL

* respect slice timeout in favor of others

* added trailing comma
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daoready @mistercrunch @codecov-io