Add support for IE 11 for markup slices #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces. Add allow-top-navigation and allow-popups to support links within iframes
This was referenced Oct 23, 2017
xrmx
reviewed
Oct 23, 2017
| @@ -23,9 +24,11 @@ function markupWidget(slice, payload) { | |||
| <iframe id="${iframeId}" | |||
| frameborder="0" | |||
| height="${slice.height()}" | |||
| sandbox="allow-scripts"> | |||
| sandbox="allow-same-origin allow-scripts allow-top-navigation allow-popups"> | |||
There was a problem hiding this comment.
Do we really need the allow-top-navigation allow-popups part?
There was a problem hiding this comment.
These are to fix #3672. When the markup slice was moved to use iframe, any link inside the slice would only open within the slice and links meant to be opened in another tab/window did nothing.
We use this for documentation and referencing other sites.
allow-top-navigationlets users create a link withtarget="_top"that will open the link in the same taballow-popupslets users create a link withtarget="_blank"that will open the link in a new tab
Without these two fields links will only open inside the iframe itself
| </iframe>`); | ||
| $('#' + iframeId)[0].srcdoc = html; | ||
|
|
||
| const iframe = $('#' + iframeId)[0]; |
There was a problem hiding this comment.
indentation is off and while we are at it we may just use a plain dom js function instead of jquery
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Add srcdoc-polyfill tosupport Internet Explorer iframes in markup slices. Add allow-top-navigation and allow-popups to support links within iframes * Remove jquery from markup.js
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow-top-navigationandallow-popupsto support links within iframes: URL link to parent or blank does not work within Markup or Separator widget #3672Because srcdoc-polyfill uses a
javascript:URL for thesrcattribute, theallow-scriptsandallow-same-originsandbox options need to be set, otherwise Internet Explorer will not be able to execute the script. This technically breaks all sandboxing as any javascript within the iframe can now manipulate the iframe element itself as well as any other element on the page.Added
allow-top-navigationto support links in the markup slice withtarget="_top"Added
allow-popupsto support links in the markup slice withtarget="_blank"