Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add grpc serializer #6992

Merged
merged 7 commits into from
Nov 10, 2024

Conversation

PleaseGiveMeTheCoke
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#6990

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added module/core core module module/serializer serializer module labels Nov 10, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 10, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpc decode和encode需要将其中的序列化方式改为grpc
GRPC decoding and encoding need to change the serialization method in it to grpc

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.66%. Comparing base (835ef47) to head (5de2f37).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/serializer/protobuf/GrpcSerializer.java 0.00% 17 Missing ⚠️
.../apache/seata/core/rpc/netty/grpc/GrpcEncoder.java 0.00% 2 Missing ⚠️
.../apache/seata/core/rpc/netty/grpc/GrpcDecoder.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6992      +/-   ##
============================================
- Coverage     52.67%   52.66%   -0.02%     
- Complexity     6572     6573       +1     
============================================
  Files          1125     1126       +1     
  Lines         39924    39942      +18     
  Branches       4676     4678       +2     
============================================
+ Hits          21031    21034       +3     
- Misses        16897    16912      +15     
  Partials       1996     1996              
Files with missing lines Coverage Δ
...g/apache/seata/core/serializer/SerializerType.java 69.56% <100.00%> (+1.38%) ⬆️
.../apache/seata/core/rpc/netty/grpc/GrpcDecoder.java 0.00% <0.00%> (ø)
.../apache/seata/core/rpc/netty/grpc/GrpcEncoder.java 0.00% <0.00%> (ø)
...ache/seata/serializer/protobuf/GrpcSerializer.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes changed the title Add grpc serializer feature: add grpc serializer Nov 10, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 60a81b1 into apache:2.x Nov 10, 2024
7 checks passed
@funky-eyes funky-eyes mentioned this pull request Nov 11, 2024
1 task
wt-better pushed a commit to wt-better/seata that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module module/serializer serializer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants