Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g #5498

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Apr 7, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix the full table scan issue with 'setDate' condition in Oracle 10g

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我抛个问题出来
1.超过7天的undolog是否需要只删除status=1的情况? 因为这个时间是可以由用户改的,很可能改成1天,那么被脏写的数据的undolog会被删除,到时候可能又会让社区背锅
2.目前rt侧的metrics没有,有必要把那个client metrics合并一下,因为server侧的metrics还是比较总体的,client有了后,针对这块像业务方就可以自行配置相关的监控告警,不需要由基建运维人员去做相关的转达了

@funky-eyes funky-eyes added this to the 2.0.0 milestone Apr 8, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 1.x也合并下这个pr吧,如果考虑到未来可能要加上status做删除,不妨将status和datetime做个组合索引吧

@slievrly slievrly merged commit 9b35ba9 into apache:2.x Apr 13, 2023
liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Apr 20, 2023
slievrly added a commit to slievrly/fescar that referenced this pull request Apr 26, 2023
Pil0tXia pushed a commit to Pil0tXia/seata that referenced this pull request Jun 14, 2023
my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit)

Squashed commit:

[c97f409] mychange 1

my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

[8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604)

[b2d4584] bugfix: fix log in participant transaction role (apache#5594)

[d0d012c] feature: support sqlserver in AT mode (apache#3887)

[54bd3ca] feature:support MS SqlServer on the server side of AT mode (apache#4033)

[d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577)

[0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576)

[7e40e05] bugfix: fix mariadb rollback failed (apache#5558)

[ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556)

Signed-off-by: slievrly <[email protected]>

[0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549)

Signed-off-by: slievrly <[email protected]>

[1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531)

[c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523)

[83493d9] optimize: optimize FenceHandler for oracle (apache#5519)

[9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants