Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hotkey): add a function test of hotkey detection #665

Merged
merged 29 commits into from
Jan 9, 2021
Merged

feat(hotkey): add a function test of hotkey detection #665

merged 29 commits into from
Jan 9, 2021

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Dec 29, 2020 •
edited
Loading

Add a function test of hotkey detection, and fix some bugs

  1. Change the default value of occurrence_threshold hot_bucket_variance_threshold and hot_key_variance_threshold to improve stability.
  2. Fix some logs and error hints.
  3. Introduce c_escape_string to print not printable characters.

@Smityz Smityz changed the title test(hotkey): add function test of hotkey detection test(hotkey): add a function test of hotkey detection Dec 30, 2020
@hycdong hycdong changed the title test(hotkey): add a function test of hotkey detection feat(hotkey): add a function test of hotkey detection Jan 6, 2021
@acelyc111 acelyc111 merged commit 685bbd2 into apache:master Jan 9, 2021
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
fix: time utils overflow, meta_split_service lock (#665)
f80fba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@hycdong hycdong hycdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smityz @hycdong @levy5307 @acelyc111