-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shell): count_data return estimate count by default #519
Merged
acelyc111
merged 11 commits into
apache:master
from
foreverneverer:refactor-count-data-style
Apr 16, 2020
Merged
feat(shell): count_data return estimate count by default #519
acelyc111
merged 11 commits into
apache:master
from
foreverneverer:refactor-count-data-style
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
changed the title
Refactor count data style
refactor: count_data return estimate count defaultly
Apr 15, 2020
levy5307
reviewed
Apr 16, 2020
levy5307
reviewed
Apr 16, 2020
levy5307
reviewed
Apr 16, 2020
…us into refactor-count-data-style
acelyc111
reviewed
Apr 16, 2020
neverchanje
changed the title
refactor: count_data return estimate count defaultly
feat(shell): count_data return estimate count by default
Apr 16, 2020
neverchanje
reviewed
Apr 16, 2020
neverchanje
reviewed
Apr 16, 2020
neverchanje
previously approved these changes
Apr 16, 2020
hycdong
reviewed
Apr 16, 2020
foreverneverer
force-pushed
the
refactor-count-data-style
branch
from
April 16, 2020 06:28
bed16e2
to
8418fea
Compare
neverchanje
approved these changes
Apr 16, 2020
hycdong
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
count_data
need scan all online records to get precise result, which may affectcluster availability, so here define
precise = false
defaultly and it will return estimatecount immediately.
What is changed and how it works?
Define
precise = false
defaultly, if want to get precise result, user must add[-c|--precise]
explictly.Check List
Tests
Related changes
Note
If some key-value is duplicate(usually written multiple times), the value of key number will be count multi time, so only after compaction, the value just be relatively more accurate.