refactor: change the way to call replication_ddl_client::set_app_envs #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
neverchanje
reviewed
Sep 23, 2019
neverchanje
previously approved these changes
Sep 23, 2019
| auto err_resp = sc->ddl_client->set_app_envs(sc->current_app_name, keys, values); | ||
| dsn::error_s err = err_resp.get_error(); | ||
| std::string hint_msg; | ||
| if (err.is_ok()) { |
There was a problem hiding this comment.
err is ok, 这个听起来太奇怪了. 建议改成err_code之类的. 而且response的error和response的信息里的error, 可以从命名上区分的更清楚些
There was a problem hiding this comment.
要改就改 error_s 的名字。这个在 rocksdb 叫 Status::isOK，在 rust 叫 Result::is_ok，最后其实就是一个写法的问题。
There was a problem hiding this comment.
现在就专注于这里的表述就好了, 变量名改好就足够了. is_ok()这个没有什么问题, 我上面没表述清楚
There was a problem hiding this comment.
我也觉得改就改errors_s的名字最好，单纯从类型和变量名来看，err这个变量起的其实没什么问题，你上面说的err is ok奇怪说起来还是error_s::is_ok()的问题，改变量也改变不了什么
neverchanje
approved these changes
Sep 24, 2019
neverchanje
changed the title
qinzuoyan
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Change the way to call set_app_replication_ddl_client::set_app_envs, becasue the return of this method is changed
What is changed and how it works?
the calling of set_app_replication_ddl_client::set_app_envs is changed
Check List
Tests
yes