Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test failed and update rdsn #384

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Aug 26, 2019

What problem does this PR solve?

  • fix some unit tests
  • update rdsn and update some cmake files

What is changed and how it works?

  • fix unit test multi_remove failed
    • rdsn #293 update fail point usage, but not apply new usage to multi_remove, this pr fix it
  • fix function test restore and recovery failed
    • pegasus configs: minimize config-server.ini to config.min.ini #370 remove config-server.ini and create config.min.ini, however, restore and recovery function test directly use config-server.ini file name and dynamically modify config in those tests, delete the file will lead to test failed
    • Moreover, config.min.ini format file adding two space characters on the beginning of the line, which leads to modifying config failed, so add \s* to identify space characters in regex for sed command
    • Besides, config.min.ini remove some configs used in those tests, add them to make tests pass
      • add thread pool THREAD_POOL_LOCAL_SERVICE for restore test
      • update worker count to 4 for 'threadpool..default', because recovery test require thread pool THREAD_POOL_META_SERVER has more than one worker
      • add recover_from_replica_server config for recovery test
  • update rdsn
    • rdsn #291, add boost::regex in some cmake files

Check List

Tests

  • Unit test

Tips

  • current travis script could not notify tests error well, @vagetablechicken will fix it in further pull request

qinzuoyan
qinzuoyan previously approved these changes Aug 26, 2019
@hycdong
Copy link
Contributor Author

hycdong commented Aug 26, 2019

Tips:

  • add 'on_travis' option for pegasus function test to skip some time-cosuming function tests. It will skip restore and recovery function test at present
  • fix pre-build and zk url

@qinzuoyan qinzuoyan merged commit dea2bd9 into apache:master Aug 27, 2019
@neverchanje neverchanje mentioned this pull request Oct 29, 2019
@hycdong hycdong deleted the fix-cmake branch June 3, 2020 06:59
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants