Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1669: jBPM Quarkus DevUI seems to not update the # of items #2814

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bncriju
Copy link
Contributor

@bncriju bncriju commented Dec 16, 2024

The wrong behavior is rectified by making the Process Instances, Tasks and Jobs to get dynamically updated, as and when user defines a process instance.

Closes apache/incubator-kie-issues#1669

Please note that earlier pull request got auto closed while renamed the branch name to match the correct kie-issue and the comments in the previous pull request are already incorporated in this one.

@bncriju bncriju requested a review from tiagobento as a code owner December 16, 2024 12:57
@yesamer yesamer requested a review from pefernan December 16, 2024 13:45
@yesamer yesamer requested a review from danielzhe December 17, 2024 08:55
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bncriju great work! I cannot get the counts initialized to 0 the first time I open Dev UI for first time (they stay as -). Would you mind taking a look?

case "JobEvent":
maybeRun(onJobEvent);
break;
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can get rid of the default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

public void refresh() {
vertx.setTimer(500, id -> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timer looks like to short, in slow laptops (like main) this may not work, but I think we can go with it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and adjusted to 1000 instead of 500

@bncriju
Copy link
Contributor Author

bncriju commented Dec 19, 2024

Thanks for the comments @pefernan. Still cannot get the counts initialized to 0 the first time I open Dev UI for first time (they stay as -), but this works fine as expected when we open process-compact-architecture.

@bncriju bncriju requested a review from pefernan December 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jBPM Quarkus DevUI seems to not update the # of items
2 participants