-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1584: [kn-plugin-workflow] added --wait to kn workflow deploy
#2800
base: main
Are you sure you want to change the base?
Conversation
workflow:
|
I think you should copy the |
@ricardozanini as far as I see, we don't have minikube or kind to run pure tests in gh actions ... |
@treblereel to get them working here:
I think we want to have same thing as in operator e2e workflow we had, https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/.github/workflows/e2e.yml Anyway, apologies for me being so not ready here, will provide review by the EOW. |
@domhanak thank you. Totally fine, I'm just not sure it's ok to run kind for tests. If it's allowed, I will be more than happy to use it |
@treblereel see: https://github.com/apache/incubator-kie-tools/blob/main/packages/sonataflow-operator/package.json#L41 You can have something slightly simpler since we don't need to replicate the heavy tests here. But we are already using KIND in GHA. |
66b6175
to
a2b2075
Compare
045c78f
to
26f38c1
Compare
issue: apache/incubator-kie-issues#1584