Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1677: [serverless-workflow-diagram-editor] marshallers (json/yaml) must support stateExecTimeout.(total/single) properties #2795

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

treblereel
Copy link
Contributor

@treblereel treblereel commented Dec 7, 2024

@treblereel
Copy link
Contributor Author

Could not transfer artifact org.kie:kogito-addons-quarkus-jobs-management:pom:999-20241016-SNAPSHOT from/to apache.snapshots (https://repository.apache.org/snapshots): transfer failed for https://repository.apache.org/snapshots/org/kie/kogito-addons-quarkus-jobs-management/999-20241016-SNAPSHOT/kogito-addons-quarkus-jobs-management-999-20241016-SNAPSHOT.pom: Connect to repository.apache.org:443 [repository.apache.org/65.109.119.155] failed: Connection timed out -> [Help 1]

@ricardozanini ricardozanini changed the title [serverless-workflow-diagram-editor] marshallers (json/yaml) must sup… [serverless-workflow-diagram-editor] marshallers (json/yaml) must support stateExecTimeout.(total/single) properties Dec 9, 2024
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right to me, but I'm not a SME for this package. Adding @handreyrc

Copy link
Contributor

@handreyrc handreyrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @treblereel!

It looks good to me and I couldn't find any issues.

Thanks for fixing it!!!

@treblereel treblereel changed the title [serverless-workflow-diagram-editor] marshallers (json/yaml) must support stateExecTimeout.(total/single) properties kie-issues#1677: [serverless-workflow-diagram-editor] marshallers (json/yaml) must support stateExecTimeout.(total/single) properties Dec 12, 2024
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I am not able to reproduce the issue. I am missing some unit test for this, or even IT if not possible.
We have this [1], but after trying to run it locally it does not seem to work now. Would be enough if we add a file that has the stateExecTimeout and check the marshaling roundtrip. Let me know your take on this please.

[1] https://github.com/apache/incubator-kie-tools/tree/main/packages/serverless-workflow-diagram-editor/sw-editor/sw-editor-kogito-app/src/test/resources/org/kie/workbench/common/stunner/sw/client/selenium

@treblereel
Copy link
Contributor Author

@domhanak thanks, well, to do such tests we could add j2cl tests to cover all cases, I think it's out of the scope, simple because its more complex than initial issue, but I will be happy to do that. We can create an issue.

@treblereel treblereel merged commit a165dcb into apache:main Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants