kie-issues#2789: [sonataflow-operator] Implement DB Migrator Changes into SonataFlow Operator #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
requested changes
Dec 5, 2024
packages/sonataflow-operator/api/v1alpha08/sonataflowplatform_services_types.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/dbMigratorJob.go
Outdated
Show resolved
Hide resolved
| const ( | ||
| dbMigrationJobName = "sonataflow-db-migrator-job" | ||
| dbMigrationContainerName = "db-migration-container" | ||
| dbMigratorToolImage = "quay.io/rhkp/incubator-kie-kogito-service-db-migration-postgresql:latest" |
There was a problem hiding this comment.
This image must come from the image package. So can you bring that here? Or we can merge the image first and then you review this const. I'm about to change this versioning/image naming in the operator package to read this info from ENV/Configuration.
There was a problem hiding this comment.
Updated to "docker.io/apache/incubator-kie-kogito-db-migrator-tool:latest" as named in DB Migrator Image package here.
There was a problem hiding this comment.
For now, unresolving this and reverting to old image for sake of seeing how CI behaves.
packages/sonataflow-operator/internal/controller/platform/dbMigratorJob.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/dbMigratorJob.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/dbMigratorJob.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/dbMigratorJob.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/services/secrets.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/services/services.go
Show resolved
Hide resolved
...est/e2e/testdata/platform/persistence/service_based_db_migration/02-sonataflow_platform.yaml
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_Job.go
Outdated
Show resolved
Hide resolved
wmedvede
reviewed
Dec 20, 2024
packages/sonataflow-operator/api/v1alpha08/sonataflow_persistence_types.go
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Outdated
Show resolved
Hide resolved
packages/sonataflow-operator/internal/controller/platform/db_migrator_job.go
Outdated
Show resolved
Hide resolved
rhkp
force-pushed
the
flpath-1909-work
branch
from
503f490 to
ab197e9
Compare
|
Can someone please help me understand the relationship between this PR and #2697? This PR's issue has no description, which makes it hard to follow what's the overall plan for the DB Migrator image. Thanks! |
rhkp
force-pushed
the
flpath-1909-work
branch
from
90cdbd4 to
00e2a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2789
Implement DB Migrator Changes into SonataFlow Operator.