kie-issues#1613: Add `CI :: License headers / check` GitHub Actions workflow #2746

jomarko · 2024-11-15T13:15:52Z

This is partial fix of the issue apache/incubator-kie-issues#1613 as we open one PR per repository.

jomarko · 2024-11-15T13:19:15Z

.rat-excludes

+**/META-INF/beans.xml
+**/licenses/**
+
+### kie-tools specific excludes


this is probably most complicated repository we have, what I need from reviewers is to help with finalization of the exclude patterns, once done and we are sure all what is needed is excluded from 'apache-rat-check', I will fix those files == add license there.

tiagobento · 2024-11-15T15:40:41Z

.github/workflows/pr-rat-check.yml

+
+      - name: Download Apache RAT
+        run: |
+          curl -LO https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.17-SNAPSHOT/apache-rat-0.17-20241115.065104-374.jar


I don't think we should be using a SNAPSHOT version.

I agree, however the stable version 16 does not support glob pattern in the '.rat-excludes' file, that is why I used 17-SNAPSHOT.

My idea was to use this specific snapshot version until there is stable/final 17, we could track this in kie-issues ticket?

If you say we need to use stable/final 16, we need to list every single excluded file in .rat-excludes

Hmm.... understand... I'm not a big fan os glob exclusions, to be honest, as I think they make it too easy to add stuff to the excluded list. Idk, first I think we need an assessment of which files we should be excluding from "CI :: Check license headers", then I think we can discuss the best approach to do it... WDYT please?

Ok, I will prepare a spreadsheet with files, we need to discuss, FYI, even excluding:

**/target/** **/node_modules/** **/dist/** **/dist-dev/** **/dist-tests/** **/dist-tests-e2e/** **/python-venv/**

we need to discuss ~995 files

shared privately

It shouldn't be necessary to include anything that is in the .gitignore...

Hi,

I'm not a big fan os glob exclusions, to be honest, as I think they make it too easy to add stuff to the excluded list

apache-rat 0.16 uses filename with regex e.g. .*\.csv. I think "easy to add" is not so different between apache-rat 0.16 (regex) and 0.17 (glob pattern). Rather, apache-rat 0.17 glob pattern can express file paths, while apache-rat 0.16 cannot express things like **/optaplanner-examples/data/**/import/**. I'll ask about the preference in dev ML.

I'm not against the assessment of excluding files at all. Thanks!

tiagobento

Thank you for starting this effort @jomarko ! I made some suggestions for us to focus on the "what" (Checking license headers), instead of the "how" (Apache RAT).

.github/workflows/pr-rat-check.yml

tiagobento · 2024-11-15T15:44:11Z

.github/workflows/pr-rat-check.yml

Please name this ci_check_license_headers.yaml

tiagobento · 2024-11-15T15:44:41Z

.github/workflows/pr-rat-check.yml

+on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]


I think making it run on merges to main would be good too... We can use the same triggers we have for ci_build.yaml

.github/workflows/pr-rat-check.yml

Co-authored-by: Tiago Bento <[email protected]>

tkobayas · 2024-11-21T07:55:44Z

.rat-excludes

+packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-emf/src/main/java/org/eclipse/dd/di/impl/StyleImpl.java
+packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-emf/src/main/java/org/eclipse/dd/di/util/DiAdapterFactory.java
+packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-emf/src/main/java/org/eclipse/dd/di/util/DiSwitch.java
+packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-emf/src/main/java/org/eclipse/dd/di/util/DiValidator.java


listing every excluded single file is nice. However, this format (file path) doesn't work with apache-rat 0.16.1. Please confirm.

Per my testing so far, apache-rat 0.16.1 supports file name without its file path (aaa.txt) or directory name (ccc/*). So far, my idea is only listing file names to exclude (It means listing like DiValidator.java, so it would affect all DiValidator.java in any paths). If you find another way to express file paths, it would be great.

Another idea is to fall back to apache-rat 0.17 and listing every excluded single file as this PR. The problem of "snapshot is pruned" could be resolved by hosting the file somewhere (e.g. incubator-kie-kogito-pipelines)... it may not sound good though.

tkobayas · 2024-11-21T09:51:20Z

.rat-excludes

+packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/FileSaver.min.js.back
+packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/canvas2svg.js.back
+packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/client/util/TimeUnit.java
+packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/compat/javax/annotation/processing/Generated.java


@porcelli Per https://lists.apache.org/thread/nrq50szwx37doopb23wyq33v0t3bbccg , I think Generated.java needs to be listed in LICENSE as Category B or X. But if it's one time listing for 10.0.0, it may not be needed in main. Thoughts?

tkobayas · 2024-11-21T10:04:10Z

.rat-excludes

+packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-webapp-kogito-marshaller/src/main/resources/DI.xsd
+packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-webapp-kogito-marshaller/src/main/resources/DMN12.xsd
+packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-webapp-kogito-marshaller/src/main/resources/DMNDI12.xsd
+packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-emf/src/main/java/org/eclipse/bpmn2/Activity.java


@porcelli @jomarko Ohh, these files with org/eclipse package classes has EPL license which is Category B. They need to be in LICENSE, right?

(I haven't fully checked the source codes. Just reported what I happened to find)

tiagobento · 2024-11-22T00:31:47Z

@jomarko Sorry for being picky, but to to make this absolutely perfect (😄), can we rename the workflow to CI :: License headers and the name of the job from check-license-headers to simply check?

This way, instead of

we'll have

Thank you!

…ie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4

pjfanning · 2024-11-26T17:53:24Z

LICENSE

+* animate.css (http://daneden.me/animate)
+
+Version - 3.5.1
+Licensed under the MIT license - http://opensource.org/licenses/MIT


you need to include the license - not link to it

with 3rd party Apache licenses, you already have the text, so you just need say the code is available under the Apache License, Version 2.0 and the copyrights in the LICENSE (if set)

pjfanning · 2024-11-26T17:54:58Z

LICENSE

+-------------------------------------------------------------------------------------------------------------
+for packages/serverless-workflow-diagram-editor/third_party/gwtbootstrap3/extras/src/main/java/org/gwtbootstrap3/extras/notify/client/resource/css/bootstrap-notify-custom.min.cache.css
+
+?????????


is this not a Twitter MIT license?

pjfanning · 2024-11-26T17:57:00Z

LICENSE

+
+Copyright (C) 2017 Vertispan
+
+Licensed under the Apache License, Version 2.0 (the "License");


pjfanning · 2024-11-26T17:58:10Z

LICENSE

+Copyright 2007 Google Inc.
+
+Licensed under the Apache License, Version 2.0 (the "License"); you may not
+use this file except in compliance with the License. You may obtain a copy of


again - do not add full text of Apache license but we need the copyright

tkobayas

I approve this PR as the basis of NOTICE, LICENSE and rat-exclude is done. We can continue the work with new PRs, so we can focus on high priority issues (= "Category X or Category B" license) first.

This reverts commit d8e03f9.

tkobayas · 2024-11-29T01:44:45Z

@tiagobento if your "change request" is implemented, could you approve this PR? If you have some other suggestions, they could be handled by a separate PR. I hope this PR is merged soon so we can proceed to the next step. Thanks!

tiagobento · 2024-11-29T19:10:50Z

All good from my side. Merging!

…orkflow (apache#2746) Co-authored-by: Tiago Bento <[email protected]>

kie-issues#1613: Add apache-rat check github action

e63e164

This is partial fix of the issue apache/incubator-kie-issues#1613 as we open one PR per repository.

jomarko requested a review from tiagobento as a code owner November 15, 2024 13:15

jomarko added the area:monorepo label Nov 15, 2024

jomarko commented Nov 15, 2024

View reviewed changes

remove checkstyle.header.template

571eab2

tiagobento reviewed Nov 15, 2024

View reviewed changes

tiagobento changed the title ~~kie-issues#1613: Add apache-rat check github action~~ kie-issues#1613: Add Apache RAT check GitHub Actions workflow Nov 15, 2024

tiagobento requested changes Nov 15, 2024

View reviewed changes

tiagobento changed the title ~~kie-issues#1613: Add Apache RAT check GitHub Actions workflow~~ kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow Nov 15, 2024

tiagobento added the area:cicd label Nov 15, 2024

jomarko and others added 3 commits November 18, 2024 08:46

Update .github/workflows/pr-rat-check.yml

e83541f

Co-authored-by: Tiago Bento <[email protected]>

Update .github/workflows/pr-rat-check.yml

bed1c37

Co-authored-by: Tiago Bento <[email protected]>

update triggers

9f863fa

jomarko mentioned this pull request Nov 18, 2024

kie-issues#1613: Add CI :: License headers GitHub Actions workflow apache/incubator-kie-kogito-runtimes#3714

Merged

8 tasks

jomarko requested a review from tiagobento November 19, 2024 12:59

tkobayas requested a review from porcelli November 20, 2024 03:36

jomarko added 2 commits November 20, 2024 11:40

List excluded files explicitely

7681a7e

add third-party excludes

eb1037b

tkobayas reviewed Nov 21, 2024

View reviewed changes

jomarko mentioned this pull request Nov 21, 2024

[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x apache/incubator-kie-drools#6167

Merged

tkobayas reviewed Nov 21, 2024

View reviewed changes

yesamer mentioned this pull request Nov 21, 2024

Add .rat-excludes file to each repository apache/incubator-kie-issues#1613

Closed

11 tasks

jomarko added 3 commits November 21, 2024 13:47

List explicitely all files in the .rat-excludes

767a6e2

Use apache-rat v0.16.1

0d481a3

Everthing -> Everything

17003e0

jomarko added pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Nov 21, 2024

jomarko changed the title ~~kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow~~ [DO NOT MERGE][WORK IN PROGRESS]kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow Nov 21, 2024

This was referenced Nov 26, 2024

EPIC - Issues found during Apache KIE 10.0.0 release candidates verification/votes apache/incubator-kie-issues#1525

Closed

Review "3rd party Category X or Category B bundled code licenses not listed in LICENSE" for 10.0.0 apache/incubator-kie-issues#1634

Closed

jomarko added 2 commits November 26, 2024 12:54

Merge branch 'main' into kie-issues#1613

163e2b0

align with https://github.com/apache/incubator-kie-drools/blob/main/k…

3a85896

…ie-dmn/kie-dmn-feel/src/main/antlr4/org/kie/dmn/feel/parser/feel11/FEEL_1_1.g4

pjfanning reviewed Nov 26, 2024

View reviewed changes

tkobayas mentioned this pull request Nov 27, 2024

notice file for drools is not correct apache/incubator-kie-issues#1616

Closed

tkobayas approved these changes Nov 27, 2024

View reviewed changes

jomarko added 5 commits November 27, 2024 14:00

Merge branch 'main' into kie-issues#1613

0122d20

Text of the LICENSE does not repeat MIT and AP

bfa992a

Remove entries of files not present in sources zip

d8429f0

fix licenses

c552ac9

prettier --write

5e59158

jomarko removed pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Nov 27, 2024

jomarko changed the title ~~[DO NOT MERGE][WORK IN PROGRESS]kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow~~ kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow Nov 27, 2024

jomarko added 4 commits November 28, 2024 06:08

Fix 'Check hanging uncommitted files'

77de49b

Fix 'Check hanging uncommitted files' 2

48d1143

Revert "fix Chart.yaml"

29e4368

This reverts commit d8e03f9.

revert loan-pre-qualification - test cheking exact content

0a5ed1c

yesamer approved these changes Nov 29, 2024

View reviewed changes

jomarko mentioned this pull request Nov 29, 2024

kie-issues#1634: Address copyright issues jomarko/kie-tools#11

Closed

tiagobento approved these changes Nov 29, 2024

View reviewed changes

tiagobento merged commit 572afb2 into apache:main Nov 29, 2024
15 checks passed

jomarko added a commit to jomarko/kie-tools that referenced this pull request Dec 2, 2024

kie-issues#1613: Add CI :: License headers / check GitHub Actions w…

1100991

…orkflow (apache#2746) Co-authored-by: Tiago Bento <[email protected]>

jomarko mentioned this pull request Dec 2, 2024

[10.0.x] kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow #2780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kie-issues#1613: Add `CI :: License headers / check` GitHub Actions workflow #2746

kie-issues#1613: Add `CI :: License headers / check` GitHub Actions workflow #2746

jomarko commented Nov 15, 2024

jomarko Nov 15, 2024

tiagobento Nov 15, 2024

jomarko Nov 18, 2024

tiagobento Nov 19, 2024

jomarko Nov 19, 2024 •

edited

Loading

jomarko Nov 19, 2024

tiagobento Nov 20, 2024

tkobayas Nov 20, 2024 •

edited

Loading

tiagobento left a comment

tiagobento Nov 15, 2024

jomarko Nov 18, 2024

tiagobento Nov 15, 2024

jomarko Nov 18, 2024

tkobayas Nov 21, 2024

tkobayas Nov 21, 2024 •

edited

Loading

tkobayas Nov 21, 2024

tiagobento commented Nov 22, 2024

pjfanning Nov 26, 2024

pjfanning Nov 26, 2024

pjfanning Nov 26, 2024

pjfanning Nov 26, 2024

tkobayas left a comment

tkobayas commented Nov 29, 2024

tiagobento commented Nov 29, 2024


		Copyright (C) 2017 Vertispan

		Licensed under the Apache License, Version 2.0 (the "License");

kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow #2746

kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow #2746

Conversation

jomarko commented Nov 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomarko Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkobayas Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

tiagobento left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkobayas Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tiagobento commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkobayas left a comment

Choose a reason for hiding this comment

tkobayas commented Nov 29, 2024

tiagobento commented Nov 29, 2024

kie-issues#1613: Add `CI :: License headers / check` GitHub Actions workflow #2746

kie-issues#1613: Add `CI :: License headers / check` GitHub Actions workflow #2746

jomarko Nov 19, 2024 •

edited

Loading

tkobayas Nov 20, 2024 •

edited

Loading

tkobayas Nov 21, 2024 •

edited

Loading