Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Upgrade Kogito to 999-20240623-SNAPSHOT #2442

Merged
merged 7 commits into from
Jun 25, 2024
Merged

NO-ISSUE: Upgrade Kogito to 999-20240623-SNAPSHOT #2442

merged 7 commits into from
Jun 25, 2024

Conversation

pefernan
Copy link
Contributor

@pefernan pefernan commented Jun 21, 2024 •
edited
Loading

@pefernan pefernan requested a review from tiagobento as a code owner June 21, 2024 11:50
@pefernan pefernan requested review from yesamer and tiagobento and removed request for tiagobento June 21, 2024 11:51
@pefernan pefernan mentioned this pull request Jun 21, 2024
Merged
yesamer
yesamer reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pefernan

  • jit-executor is still using 20240505
Screenshot 2024-06-21 at 14 48 54

@tiagobento
Copy link
Contributor

After updating the values, you need to run a bootstrap to update the derivatives...

@pefernan pefernan force-pushed the 999-20240620-SNAPSHOT branch from 277dc23 to 7a075e4 Compare June 21, 2024 13:06
@pefernan pefernan force-pushed the 999-20240620-SNAPSHOT branch from 7a075e4 to b3a4dc5 Compare June 21, 2024 13:23
@pefernan
Copy link
Contributor Author

@yesamer yea sorry, I'm working on it. I'm having some problems with my laptop today.

As far as I know, jit-executor-native haven't been published :S

@tiagobento tiagobento changed the title NO_ISSUE: Upgrade to 999-20240620-SNAPSHOT NO-ISSUE: Upgrade to 999-20240620-SNAPSHOT Jun 21, 2024
@tiagobento tiagobento changed the title NO-ISSUE: Upgrade to 999-20240620-SNAPSHOT NO-ISSUE: Upgrade Kogito to 999-20240620-SNAPSHOT Jun 21, 2024
@tiagobento
Copy link
Contributor

Hi guys! I took the liberty to take a look at this PR, and found out that indeed the JIT Executor Native is not being published to NPM anymore. We're actually publishing it to Maven now. I updated extended-services to download and unpack the binaries from Maven, and therefore now we only depend on upstream Images and Maven artifacts.

I also updated some other references from 20240509 to 20240620. Let's see how the build goes. 🙏

@tiagobento tiagobento added the area:dependencies Pull requests that update a dependency file label Jun 21, 2024
@rodrigonull
Copy link
Contributor

FYI: a new weekly snapshot is available: 999-20240623-SNAPSHOT

@pefernan
Copy link
Contributor Author

@rodrigonull great, going to update

@tiagobento tiagobento changed the title NO-ISSUE: Upgrade Kogito to 999-20240620-SNAPSHOT NO-ISSUE: Upgrade Kogito to 999-20240623-SNAPSHOT Jun 25, 2024
@tiagobento tiagobento merged commit 16edc6e into apache:main Jun 25, 2024
14 checks passed
@pefernan pefernan deleted the 999-20240620-SNAPSHOT branch June 25, 2024 19:37
This was referenced Jun 26, 2024
Closed
Closed
@tiagobento tiagobento mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagobento tiagobento tiagobento approved these changes

@yesamer yesamer yesamer approved these changes

Assignees
No one assigned
Labels
area:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pefernan @tiagobento @rodrigonull @yesamer