Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rhkp committed Dec 19, 2024
1 parent 634ade2 commit 8769274
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/kogito-db-migrator-tool-image/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ let imageYaml = fs.readFileSync(originalYamlPath, "utf8");
const imageUrl = `${env.kogitoDbMigratorToolImage.registry}/${env.kogitoDbMigratorToolImage.account}/${env.kogitoDbMigratorToolImage.name}`;

// Replace the whole string between quotes ("") with the image name
imageYaml = imageYaml.replace(/(?<=")(.*incubator-kie-kogito-service-db-migration-postgresql.*)(?=")/gm, imageUrl);
imageYaml = imageYaml.replace(/(?<=")(.*kie-kogito-db-migrator-tool.*)(?=")/gm, imageUrl);

// Write file and then rename it to match the image name
fs.writeFileSync(originalYamlPath, imageYaml);
Expand Down
2 changes: 1 addition & 1 deletion packages/kogito-db-migrator-tool-image/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/apache/incubator-kie-tools/issues"
},
"scripts": {
"build": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && pnpm copy-assets && pnpm image:build && rimraf build && rimraf target && rimraf dist-tests-e2e",
"build": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && pnpm copy-assets && pnpm image:build && rimraf target && rimraf dist-tests-e2e",
"build:dev": "run-script-os",
"build:dev:linux": "pnpm build",
"build:dev:win32:darwin": "echo \"Build skipped on Windows and MacOS\"",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ name: org.kie.kogito.postgresql.db-migration-deps
version: "main"
artifacts:
# The following artifact comes from the package kogito-db-migrator-tool during the pnpm build:dev phase
- name: sonataflow-db-migrator-quarkus-app
- name: kogito-db-migrator-tool-quarkus-app
path: ./quarkus-app
dest: /home/kogito/bin

0 comments on commit 8769274

Please sign in to comment.