Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANNER-2411: Add solver config, constraint list, and model to Quarkus Dev UI #1381

Merged
merged 4 commits into from
Jul 20, 2021
Merged

PLANNER-2411: Add solver config, constraint list, and model to Quarkus Dev UI #1381

merged 4 commits into from
Jul 20, 2021

Conversation

Christopher-Chianelli
Copy link
Contributor

Don't know how to test this, since in order to verify it works, we need to visit the Dev UI pages.

JIRA

https://issues.redhat.com/browse/PLANNER-2411

Referenced pull requests

Checklist

  • Documentation updated if applicable.
  • Upgrade recipe provided if applicable.
How to retest this PR or trigger a specific build:
  • for a pull request build please add comment: Jenkins retest this
  • for a specific pull request build please add comment: Jenkins (re)run [optaplanner|apps|examples] tests
  • for a full downstream build please add comment: Jenkins run fdb
  • for a compile downstream build please add comment: Jenkins run cdb
  • for a full production downstream build please add comment: Jenkins execute product fdb
  • for an upstream build please add comment: Jenkins run upstream
  • for a Quarkus LTS check please add comment: Jenkins run LTS
  • for a specific Quarkus LTS check please add comment: Jenkins (re)run [optaplanner|apps|examples] LTS
  • for a Native check please add comment: Jenkins run native
  • for a specific Native LTS check please add comment: Jenkins (re)run [optaplanner|apps|examples] native

@triceo
Copy link
Contributor

triceo commented Jun 15, 2021

The way to test this is via Selenium, Cypress or some other tool like that. Even though I would advise against it - those tools, in my opinion, bring more pain than good.

Did you consider asking in the Quarkus Zulip chat? Perhaps they have a way to test these things somehow.

@Christopher-Chianelli
Copy link
Contributor Author

Link to Zulip chat: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Testing.20Dev.20UI

@kie-ci
Copy link
Contributor

kie-ci commented Jun 15, 2021

The (build) examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Jun 15, 2021

The (build) optaplanner check is successful.

@kie-ci
Copy link
Contributor

kie-ci commented Jun 15, 2021

The (build) apps check is successful.

@Christopher-Chianelli
Copy link
Contributor Author

Seems quarkusio/quarkus#17915 prevents us adding tests for Dev UI within this repo (dev ui fails to render because optaplanner-quarkus is a local extension). Which means to test this, it need to be in a different repo, like optaplanner-quickstarts

@Christopher-Chianelli Christopher-Chianelli mentioned this pull request Jun 16, 2021
Closed
@Christopher-Chianelli
Copy link
Contributor Author

Tests are in https://github.com/kiegroup/optaplanner-quickstarts/pull/122

@Christopher-Chianelli Christopher-Chianelli mentioned this pull request Jun 17, 2021
Closed
2 tasks
@Christopher-Chianelli
Copy link
Contributor Author

Moved the integration tests to this repo as the Quarkus issue is fixed. It needed to be in its own module; using integration-tests repo causes a "cannot restart started application", using deployment causes it to not run (probably because it requires Vert.x to be active)

triceo
triceo suggested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some room for improvement, I think.

optaplanner-quarkus-integration/optaplanner-quarkus/pom.xml Show resolved Hide resolved
...uarkus/deployment/src/main/java/org/optaplanner/quarkus/deployment/OptaPlannerProcessor.java Show resolved Hide resolved
...uarkus/deployment/src/main/java/org/optaplanner/quarkus/deployment/OptaPlannerProcessor.java Outdated Show resolved Hide resolved
...arkus-integration/optaplanner-quarkus/deployment/src/main/resources/dev-templates/model.html Outdated Show resolved Hide resolved
...ntegration/optaplanner-quarkus/deployment/src/main/resources/dev-templates/solverConfig.html Outdated Show resolved Hide resolved
...-quarkus/runtime/src/main/java/org/optaplanner/quarkus/devui/OptaPlannerDevUIProperties.java Outdated Show resolved Hide resolved
.../runtime/src/main/java/org/optaplanner/quarkus/devui/OptaPlannerDevUIPropertiesSupplier.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

62.9% 62.9% Coverage
16.2% 16.2% Duplication

@kie-ci
Copy link
Contributor

kie-ci commented Jul 13, 2021

The (build) apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Jul 13, 2021

The (build) examples check has failed. Please check the logs.

@Christopher-Chianelli
Copy link
Contributor Author

jenkins retest this

@kie-ci
Copy link
Contributor

kie-ci commented Jul 19, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Jul 19, 2021

The (build) apps check has failed. Please check the logs.

@Christopher-Chianelli
Copy link
Contributor Author

@triceo this is green now and is approved

@triceo triceo merged commit 2299d87 into apache:master Jul 20, 2021
@Christopher-Chianelli Christopher-Chianelli deleted the PLANNER-2411 branch August 23, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christopher-Chianelli @triceo @kie-ci