[incubator-kie-issues-1308] Exceptions in Service process #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
incubator-kie-issues-1308
branch
from
b9927cd to
6a70a1c
Compare
| assertThat(workItem).isNotNull(); | ||
| kruntime.getKogitoWorkItemManager().completeWorkItem(workItem.getStringId(), null); | ||
| // Check that event was passed to Event SubProcess (and grabbed by WorkItemHandler); | ||
| assertThat(caughtEventObjectHolder[0] != null && caughtEventObjectHolder[0] instanceof KogitoWorkItem).withFailMessage("Event was not passed to Event Subprocess.").isTrue(); |
There was a problem hiding this comment.
Is this assert missing in the new version of the test?
There was a problem hiding this comment.
fixed, also the proper state of the process.
|
|
||
| org.kie.kogito.process.ProcessInstance<ExceptionThrowingServiceProcessModel> instance3 = definition.createInstance(model); | ||
| instance3.start(); | ||
| assertThat(instance3.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_ACTIVE); |
There was a problem hiding this comment.
I currently don't see the value of this test:
- It would be sufficient just to start a single instance
- The assert should check if the message that is logged is in the defined format
{0} - {1} - {2} - {3}
elguardian
force-pushed
the
incubator-kie-issues-1308
branch
from
6a70a1c to
397adc1
Compare
martinweiler
approved these changes
Jun 20, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1308