Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1068] Fix gradle build output #3471

Merged
merged 12 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.util.Map;
import java.util.stream.Stream;

import org.drools.codegen.common.AppPaths;
import org.drools.io.FileSystemResource;
import org.drools.scenariosimulation.api.model.ScenarioSimulationModel;
import org.drools.scenariosimulation.api.model.ScesimModelDescriptor;
Expand All @@ -53,7 +54,7 @@ public class KogitoDMNScenarioRunnerHelper extends DMNScenarioRunnerHelper {

private DMNRuntime dmnRuntime = initDmnRuntime();

private static final String targetFolder = File.separator + "target" + File.separator;
private static final String targetFolder = File.separator + AppPaths.TARGET_DIR + File.separator;
private static final String generatedResourcesFolder = targetFolder + "generated-resources" + File.separator;

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import java.io.File;
import java.io.FileReader;
import java.io.IOException;
import java.nio.file.Path;
import java.text.MessageFormat;
import java.util.Collection;
import java.util.Collections;
Expand Down Expand Up @@ -258,7 +257,7 @@ protected abstract static class AbstractBuilder implements Builder {
protected Predicate<String> classAvailabilityResolver = this::hasClass;
protected Predicate<Class<?>> classSubTypeAvailabilityResolver = c -> false;
// default fallback value (usually overridden)
protected AppPaths appPaths = AppPaths.fromProjectDir(new File(".").toPath(), Path.of(".", AppPaths.TARGET_DIR));
protected AppPaths appPaths = AppPaths.fromProjectDir(new File(".").toPath());
protected KogitoGAV gav;

protected AbstractBuilder() {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.NoSuchElementException;
import java.util.Optional;

import org.drools.codegen.common.AppPaths;
import org.drools.codegen.common.di.impl.CDIDependencyInjectionAnnotator;
import org.drools.util.StringUtils;
import org.junit.jupiter.api.AfterAll;
Expand Down Expand Up @@ -80,7 +81,7 @@ public static void setup() {
String filePrefix = URLEncoder.encode(getSanitizedClassName(KIE_PMML_MODEL.getFileName().replace(".pmml", "")));
String classPrefix = URLEncoder.encode(getSanitizedClassName(KIE_PMML_MODEL.getName()));
expectedUrl = String.format("/%s/%s", filePrefix, classPrefix);
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, "target/test-classes");
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, String.format("%s/test-classes", AppPaths.TARGET_DIR));
}

@AfterAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.Collections;
import java.util.List;

import org.drools.codegen.common.AppPaths;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.params.ParameterizedTest;
Expand All @@ -46,7 +47,7 @@ class PredictionCodegenFactoryTest {

@BeforeAll
public static void setup() {
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, "target/test-classes");
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, String.format("%s/test-classes", AppPaths.TARGET_DIR));
}

@AfterAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.function.Function;
import java.util.stream.Stream;

import org.drools.codegen.common.AppPaths;
import org.drools.codegen.common.GeneratedFile;
import org.drools.codegen.common.GeneratedFileType;
import org.junit.jupiter.api.AfterAll;
Expand Down Expand Up @@ -68,7 +69,7 @@ class PredictionCodegenGenerateTest {

@BeforeAll
public static void setup() {
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, "target/test-classes");
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, String.format("%s/test-classes", AppPaths.TARGET_DIR));
}

@AfterAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.util.function.Function;
import java.util.stream.Stream;

import org.drools.codegen.common.AppPaths;
import org.drools.codegen.common.GeneratedFile;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
Expand All @@ -51,7 +52,7 @@ class PredictionCodegenInternalGenerateTest {

@BeforeAll
public static void setup() {
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, "target/test-classes");
System.setProperty(INDEXFILE_DIRECTORY_PROPERTY, String.format("%s/test-classes", AppPaths.TARGET_DIR));
}

@AfterAll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.lang.reflect.Modifier;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.file.Path;
import java.util.Collection;
import java.util.Iterator;
import java.util.Map;
Expand All @@ -43,7 +44,7 @@
import org.kie.kogito.codegen.api.context.impl.JavaKogitoBuildContext;
import org.kie.kogito.codegen.api.context.impl.QuarkusKogitoBuildContext;
import org.kie.kogito.codegen.api.context.impl.SpringBootKogitoBuildContext;
import org.kie.kogito.codegen.core.utils.GeneratedFileWriter;
import org.drools.codegen.common.GeneratedFileWriter;
import org.kie.kogito.codegen.decision.DecisionCodegen;
import org.kie.kogito.codegen.prediction.PredictionCodegen;
import org.kie.kogito.codegen.process.ProcessCodegen;
Expand All @@ -55,6 +56,8 @@

public abstract class AbstractKieMojo extends AbstractMojo {

protected static final GeneratedFileWriter.Builder generatedFileWriterBuilder = GeneratedFileWriter.builder("kogito","kogito.codegen.resources.directory", "kogito.codegen.sources.directory");

@Parameter(required = true, defaultValue = "${project.basedir}")
protected File projectDir;

Expand All @@ -67,11 +70,8 @@ public abstract class AbstractKieMojo extends AbstractMojo {
@Parameter(required = true, defaultValue = "${project.build.outputDirectory}")
protected File outputDirectory;

@Parameter(defaultValue = "${project.build.directory}/" + GeneratedFileWriter.DEFAULT_SOURCES_DIR)
protected File generatedSources;

@Parameter(defaultValue = "${project.build.directory}/" + GeneratedFileWriter.DEFAULT_RESOURCE_PATH)
protected File generatedResources;
@Parameter(required = true, defaultValue = "${project.basedir}")
protected File baseDir;

@Parameter(property = "kogito.codegen.persistence", defaultValue = "true")
protected boolean persistence;
Expand Down Expand Up @@ -102,7 +102,7 @@ protected void setSystemProperties(Map<String, String> properties) {
}

protected KogitoBuildContext discoverKogitoRuntimeContext(ClassLoader classLoader) {
AppPaths appPaths = AppPaths.fromProjectDir(projectDir.toPath(), outputDirectory.toPath());
AppPaths appPaths = AppPaths.fromProjectDir(projectDir.toPath());
KogitoBuildContext context = contextBuilder()
.withClassAvailabilityResolver(this::hasClassOnClasspath)
.withClassSubTypeAvailabilityResolver(classSubTypeAvailabilityResolver())
Expand Down Expand Up @@ -250,20 +250,27 @@ private boolean hasClassOnClasspath(String className) {
}

protected void writeGeneratedFiles(Collection<GeneratedFile> generatedFiles) {
generatedFiles.forEach(this::writeGeneratedFile);
GeneratedFileWriter writer = getGeneratedFileWriter();
generatedFiles.forEach(generatedFile -> writeGeneratedFile(generatedFile, writer));
}

protected void writeGeneratedFile(GeneratedFile generatedFile) {
GeneratedFileWriter writer = new GeneratedFileWriter(outputDirectory.toPath(),
generatedSources.toPath(),
generatedResources.toPath(),
getSourcesPath().toPath());
writeGeneratedFile(generatedFile, getGeneratedFileWriter());
}

protected void writeGeneratedFile(GeneratedFile generatedFile, GeneratedFileWriter writer) {
getLog().info("Generating: " + generatedFile.relativePath());
writer.write(generatedFile);
}

protected File getSourcesPath() {
return generatedSources;
// using runtime BT instead of static AppPaths.MAVEN to allow
// invocation from GRADLE
return Path.of(baseDir.getAbsolutePath(), AppPaths.BT.GENERATED_SOURCES_PATH.toString()).toFile();
}

protected GeneratedFileWriter getGeneratedFileWriter() {
return generatedFileWriterBuilder
.build(Path.of(baseDir.getAbsolutePath()));
}
}
Loading
Loading