-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix_#3465] Adds DMN support to SonataFlow #3468
Conversation
1afb1a1
to
4238d01
Compare
30ec623
to
753e21f
Compare
bf1710f
to
d3acdc8
Compare
Hi, I opened a thread on the dev mailing list about this, because I didn't saw one there. Let's see if we have an agreement about this there. I think it is worth discussing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fjtirado
There is only one bit I would prefer to be changed (the usage of dmn from shared model)
Thanks!
...less-workflow/kogito-serverless-workflow-dmn-parser/src/test/resources/Traffic Violation.dmn
Outdated
Show resolved
Hide resolved
* [Fix_#3465] Adding DMNWorkItemHandler * [Fix_#3465] Node approach * [Fix apache#3465] Supporting white space * [Fix apache#3465] Refactor mapping * [Fix apache#3465] Support function arguments * [Fix apache#3465] Gabrieles comment
Fixes #3465
A new DMN custom type (called "dmn") has been added to swf parser.
The mapping is either automatically performed from the workflow model (if the name matches), so there is not need to provide args. If the workflow model names does not match, the workflow writer should provide the mapping as argument of the function call.
This is the workflow definition used in the unit test (which just calls the traffiction violation decision from the workflow)
See example apache/incubator-kie-kogito-examples#1906