-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incubator-kie-issues#917: Verify Quarkus Extensions metadata in kogito-runtimes
#3401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the keyword workflow
where matters. So this PR is just for the metainfo? 'cause we might need to also change the name
accordingly to the spreadsheet: https://docs.google.com/spreadsheets/u/1/d/1gsttRcXGtwGQO469EYFDhLxJLEA7Kl3gmioR6XhGhjY/edit#gid=0
quarkus/addons/events/process/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/knative/eventing/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/jobs/messaging/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/jobs/management/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/jobs/knative-eventing/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...kus/addons/persistence/postgresql/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/persistence/rocksdb/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/process-management/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/process-svg/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...s/kogito-quarkus-extension/kogito-quarkus/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
@ricardozanini yes, this is only metadata review. I think the rename should happen after release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thx for the good work Pere and keeps things strict to the scope of the task !
@ricardozanini just updated the PR aligning the capabilities and the extensions metadata with the new namings, so we can proceed with the rename with extensions in shape. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/5/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
quarkus/addons/source-files/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/source-files/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...kus/addons/persistence/filesystem/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
quarkus/addons/process-definitions/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
quarkus/addons/tracing-decision/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...ions-extension/kogito-quarkus-predictions/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...cesses-extension/kogito-quarkus-processes/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
...ions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/pom.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments to explain
2916074
to
8ed50a4
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/8/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
Build failures apparently related to quarkusio/quarkus#20777 |
1a8e651
to
7683c15
Compare
7683c15
to
d1eeda2
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/15/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
d1eeda2
to
660ac79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/18/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
8587c62
to
6cfd454
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/19/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/20/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
ff3f534
to
c29d30b
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/25/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
Co-authored-by: Ricardo Zanini <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
- Quarkus Extensions it-tests fix
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/26/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
45d60d1
to
6b01cbf
Compare
6b01cbf
to
5635f24
Compare
@pefernan why are we having this many failures in the checks, do you know? EDIT: nvm, I saw your message on Zulip |
@ricardozanini yea, what's happening is that I changed the capabilities Id's but quarkus is still resolving the old |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/28/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse[Run project return status is zero]expected: 0 but was: 1 |
…to-runtimes` (apache#3401) * incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` * Apply suggestions from code review Co-authored-by: Ricardo Zanini <[email protected]> * Apply suggestions from code review Co-authored-by: Ricardo Zanini <[email protected]> * - added `kogito-addon-quarkus-source-files` extension metadata. * - Aligned metadata & capabilities to new naming * - fix typo * - adding `cloud` category - Quarkus Extensions it-tests fix * - cleanup --------- Co-authored-by: Ricardo Zanini <[email protected]>
Closes apache/incubator-kie-issues#917