[KOGITO-5094] Allowing byte[] as serializer/deserializer for Quarkus #1823

fjtirado · 2021-12-27T10:54:39Z

This JIRA is a first step to achieve integration with Apache Avro.
I have created two follow up JIRAS: one to replace DataEvent by CloudEvent https://issues.redhat.com/browse/KOGITO-6476 and another one to provide an example of overriding default marshaller to interact with Avro https://issues.redhat.com/browse/KOGITO-6521
The overall idea in this one is to infer the right marshaller from the channel property.
If StringSerializer or ByteSeralizer we use a default marshaller that converts the Json to byte[]/string (this keeps backward compatibility)
If different serializer we assume the serializer deals properly with the event object and we use a marshaller that keep the object intact
In addition to that, this PR fixes following issues:

A missing managed dependency for testing
EventConverterProducer and EventMarshallerProducer are not longer generated (and are now declared as DefaultBeans). This will allow users to extend them and also to "specialize" them, providing their own marshallers/unmarshallers for custom data types
A problem with future version of Quarkus. We are not longing mengling with Smallrye internals, but treating default channels as regular channels:
- MediatorConfig and ChannelRegistar are not longer used to provide a default emitter. Now all meaningful emitters are generated from configuration. For covering such cases where an Emitter and Receiver is being inject into a class but no configuration is provided to create the proper channel (for example in QuarkusEventDrivenDecission and knative example), a default dummy bean is produced.
- Before these changes, emitter/receiver for quarkus were generated as part of processes codegen, now they are generated by the addon processor. This requires changes in the existing main buildsteps in order to allow an addon to modify a generated class. The main buildstep in KogitoAssetProcessor was split in two, one that generates the sources and another that generate the classes

kie-ci · 2021-12-27T10:54:50Z

Can one of the admins verify this patch?

kie-ci · 2021-12-27T10:54:50Z

Can one of the admins verify this patch?

kie-ci · 2021-12-27T10:54:51Z

Can one of the admins verify this patch?

kie-ci · 2021-12-27T10:54:51Z

Can one of the admins verify this patch?

kie-ci · 2021-12-27T11:03:10Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2021-12-27T11:03:52Z

The (build) optaplanner-quickstarts check has failed. Please check the logs.

kie-ci · 2021-12-27T12:06:30Z

The (build) kogito-runtimes check has failed. Please check the logs.

kie-ci · 2021-12-27T13:56:21Z

The (build) kogito-apps check has failed. Please check the logs.

kie-ci · 2021-12-27T13:58:33Z

The (build) optaweb-employee-rostering check has failed. Please check the logs.

kie-ci · 2021-12-27T13:58:36Z

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

kie-ci · 2021-12-27T16:56:50Z

The (build) optaplanner-quickstarts check has failed. Please check the logs.

kie-ci · 2021-12-27T16:56:51Z

The (build) kogito-apps check has failed. Please check the logs.

kie-ci · 2021-12-27T16:56:53Z

The (build) optaweb-employee-rostering check has failed. Please check the logs.

kie-ci · 2021-12-27T16:57:06Z

The (build) optaplanner check has failed. Please check the logs.

kie-ci · 2021-12-27T16:57:27Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2021-12-27T16:57:56Z

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

kie-ci · 2021-12-27T17:01:04Z

The (build) kogito-runtimes check has failed. Please check the logs.

fjtirado · 2021-12-27T17:07:04Z

...esses/src/main/resources/class-templates/producer/EventMarshallerProducerSpringTemplate.java

@@ -31,7 +35,7 @@
    ObjectMapper mapper;

    @Bean
-    public EventMarshaller eventMarshaller(){
-        return new DefaultEventMarshaller(mapper);
+    public EventMarshaller<String> stringEventMarshaller(){


For Spring, we keep just string event marshaller at the moment

fjtirado · 2021-12-27T17:07:30Z

...sses/src/main/resources/class-templates/producer/EventMarshallerProducerQuarkusTemplate.java

@@ -32,7 +34,17 @@
    ObjectMapper mapper;

    @Produces
-    public EventMarshaller eventMarshaller(){
-        return new DefaultEventMarshaller(mapper);
+    public EventMarshaller<String> stringEventMarshaller(){


Quarkus will inject the proper marshaller depending on the generated emitter type

kie-ci · 2021-12-27T17:10:33Z

The (build) kogito-examples check has failed. Please check the logs.

...en-processes/src/main/java/org/kie/kogito/codegen/process/DefaultChannelMappingStrategy.java

kie-ci · 2021-12-27T17:11:24Z

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

kie-ci · 2021-12-27T17:11:49Z

The (build) optaplanner-quickstarts check has failed. Please check the logs.

kie-ci · 2021-12-27T17:12:05Z

The (build) optaplanner check has failed. Please check the logs.

kie-ci · 2022-01-10T11:58:18Z

The (build) kogito-runtimes check has failed. Please check the logs.

kie-ci · 2022-01-10T12:00:47Z

The (build) kogito-runtimes check has failed. Please check the logs.

kie-ci · 2022-01-10T12:42:35Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-10T13:20:29Z

The (build) kogito-runtimes check has failed. Please check the logs.

kie-ci · 2022-01-10T13:53:18Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-10T13:59:56Z

The (build) kogito-apps check has failed. Please check the logs.

kie-ci · 2022-01-10T17:49:23Z

The (build) kogito-runtimes check has failed. Please check the logs.

kie-ci · 2022-01-10T18:48:37Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-10T19:41:27Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-10T20:25:41Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-10T21:28:49Z

The (build) kogito-apps check has failed. Please check the logs.

kie-ci · 2022-01-10T22:13:18Z

The (build) kogito-examples check has failed. Please check the logs.

danielezonca · 2022-01-11T07:47:11Z

@fjtirado
I see you are still pushing new code chances to the PR, is it ready for review or still WIP?
Build is green so if you are fixing some issue I would suggest to also add some additional test to prevent regression in the future

fjtirado · 2022-01-11T08:18:46Z

ild is green so if you are fixing some issue I would suggest to also add some additional test to prevent regression in the future

Build is green now, after my lastest change, merging.

kie-ci · 2022-01-11T13:03:02Z

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

kie-ci · 2022-01-11T13:05:30Z

The (build) optaweb-employee-rostering check has failed. Please check the logs.

sonarcloud · 2022-01-11T14:27:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

kie-ci · 2022-01-11T14:56:41Z

The (build) kogito-examples check has failed. Please check the logs.

kie-ci · 2022-01-11T14:59:21Z

The (build) kogito-apps check has failed. Please check the logs.

fjtirado force-pushed the KOGITO-5094 branch from d27cb3e to cbad17c Compare December 27, 2021 16:47

fjtirado requested a review from ricardozanini December 27, 2021 16:53

fjtirado changed the title ~~[KOGITO-5094] Allowing byte[] deserializer~~ [KOGITO-5094] Allowing byte[] as serializer/deserializer for Quarkus Dec 27, 2021

fjtirado force-pushed the KOGITO-5094 branch from cbad17c to 44eea6b Compare December 27, 2021 16:59

fjtirado marked this pull request as ready for review December 27, 2021 17:00

fjtirado mentioned this pull request Dec 27, 2021

[KOGITO-5094] Update Kafka example to use byte[] serializer apache/incubator-kie-kogito-examples#1057

Closed

fjtirado commented Dec 27, 2021

View reviewed changes

...en-processes/src/main/java/org/kie/kogito/codegen/process/DefaultChannelMappingStrategy.java Outdated Show resolved Hide resolved

fjtirado requested a review from tkobayas January 10, 2022 11:47

ricardozanini approved these changes Jan 10, 2022

View reviewed changes

fjtirado force-pushed the KOGITO-5094 branch from b153e10 to e7f652e Compare January 10, 2022 17:10

fjtirado force-pushed the KOGITO-5094 branch 2 times, most recently from 4b437e8 to 18e1cc7 Compare January 10, 2022 18:21

fjtirado force-pushed the KOGITO-5094 branch from 18e1cc7 to 4eca931 Compare January 10, 2022 21:00

fjtirado added 2 commits January 11, 2022 01:29

[KOGITO-5094] Allowing byte[] serializer/deserializer

10f5c5f

[KOGITO-5094] Different generation approach

9db5cb6

fjtirado force-pushed the KOGITO-5094 branch from 4eca931 to 9db5cb6 Compare January 11, 2022 01:45

tkobayas approved these changes Jan 11, 2022

View reviewed changes

fjtirado merged commit 3864d34 into apache:main Jan 11, 2022

[KOGITO-5094] Allowing byte[] as serializer/deserializer for Quarkus #1823

[KOGITO-5094] Allowing byte[] as serializer/deserializer for Quarkus #1823

Conversation

fjtirado commented Dec 27, 2021 • edited Loading

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

fjtirado Dec 27, 2021

Choose a reason for hiding this comment

fjtirado Dec 27, 2021

Choose a reason for hiding this comment

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Dec 27, 2021

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

kie-ci commented Jan 10, 2022

danielezonca commented Jan 11, 2022

fjtirado commented Jan 11, 2022

kie-ci commented Jan 11, 2022

kie-ci commented Jan 11, 2022

sonarcloud bot commented Jan 11, 2022

kie-ci commented Jan 11, 2022

kie-ci commented Jan 11, 2022

fjtirado commented Dec 27, 2021 •

edited

Loading