Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-5817 Disable REST codegen if resteasy is not present #1643

Merged
merged 8 commits into from
Oct 20, 2021
Merged

KOGITO-5817 Disable REST codegen if resteasy is not present #1643

merged 8 commits into from
Oct 20, 2021

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Oct 5, 2021 •
edited
Loading

Throws an Exception at build-time, unless either RESTEasy or RESTEasy reactive are is present.

http://issues.redhat.com/browse/KOGITO-5817

EDIT I am rescoping this to resteasy alone for now, because there is some issue with resteasy reactive. I'll open a separate JIRA for that: https://issues.redhat.com/browse/KOGITO-6131

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 5, 2021

The (build) Apps check has failed. Please check the logs.

@evacchi evacchi mentioned this pull request Oct 6, 2021
Closed
@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) optaweb-employee-rostering check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) optaplanner-quickstarts check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 11, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 12, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 12, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 12, 2021

The (build) kogito-apps check has failed. Please check the logs.

This was referenced Oct 13, 2021
Merged
Merged
@evacchi evacchi marked this pull request as ready for review October 18, 2021 16:13
@evacchi evacchi mentioned this pull request Oct 18, 2021
Closed
@evacchi evacchi requested a review from danielezonca October 19, 2021 12:53
@evacchi evacchi requested a review from radtriste October 19, 2021 12:53
danielezonca
danielezonca approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment but approving 👍

...t/src/main/java/org/kie/kogito/quarkus/common/deployment/MissingRestCapabilityException.java Outdated Show resolved Hide resolved
@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaweb-employee-rostering check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaplanner-quickstarts check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaweb-employee-rostering check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) optaplanner-quickstarts check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@kie-ci
Copy link
Contributor

kie-ci commented Oct 19, 2021

The (build) kogito-examples check has failed. Please check the logs.

@evacchi evacchi mentioned this pull request Oct 20, 2021
Closed
@evacchi evacchi merged commit f9e5635 into apache:main Oct 20, 2021
@evacchi evacchi deleted the KOGITO-5817-optional-resteasy branch October 20, 2021 10:05
jsmrcka referenced this pull request in jsmrcka/quarkus-test-suite Dec 5, 2021
@jsmrcka
Add RESTEasy extensions to CLI apps with Kogito
7341110 
The CLI test generates an app with `kogito-quarkus-rules` extension.
After https://github.com/kiegroup/kogito-runtimes/pull/1643, Kogito
needs both `quarkus-resteasy` and `quarkus-resteasy-jackson` to be
able to build with tests - tests invoke REST endpoint.
The Kogito PR was merged in Kogito `1.13.0.Final` (in Quarkus Platform
`2.5.0.CR1`)
@jsmrcka jsmrcka mentioned this pull request Dec 5, 2021
Merged
jsmrcka referenced this pull request in jsmrcka/quarkus-test-suite Dec 7, 2021
@jsmrcka
Add RESTEasy extensions to CLI apps with Kogito
08b69fc 
The CLI test generates an app with `kogito-quarkus-rules` extension.
After https://github.com/kiegroup/kogito-runtimes/pull/1643, Kogito
needs both `quarkus-resteasy` and `quarkus-resteasy-jackson` to be
able to build with tests - tests invoke REST endpoint.
The Kogito PR was merged in Kogito `1.13.0.Final` (in Quarkus Platform
`2.5.0.CR1`)
DavideD referenced this pull request in DavideD/quarkus-test-suite Dec 16, 2021
@jsmrcka @DavideD
Add RESTEasy extensions to CLI apps with Kogito
c5075d9 
The CLI test generates an app with `kogito-quarkus-rules` extension.
After https://github.com/kiegroup/kogito-runtimes/pull/1643, Kogito
needs both `quarkus-resteasy` and `quarkus-resteasy-jackson` to be
able to build with tests - tests invoke REST endpoint.
The Kogito PR was merged in Kogito `1.13.0.Final` (in Quarkus Platform
`2.5.0.CR1`)
rsvoboda referenced this pull request in rsvoboda/quarkus-test-suite Feb 3, 2022
@jsmrcka @rsvoboda
Add RESTEasy extensions to CLI apps with Kogito
63f39a1 
The CLI test generates an app with `kogito-quarkus-rules` extension.
After https://github.com/kiegroup/kogito-runtimes/pull/1643, Kogito
needs both `quarkus-resteasy` and `quarkus-resteasy-jackson` to be
able to build with tests - tests invoke REST endpoint.
The Kogito PR was merged in Kogito `1.13.0.Final` (in Quarkus Platform
`2.5.0.CR1`)
fedinskiy referenced this pull request in quarkus-qe/quarkus-test-suite Feb 3, 2022
@jsmrcka @fedinskiy
Add RESTEasy extensions to CLI apps with Kogito
932ca20 
The CLI test generates an app with `kogito-quarkus-rules` extension.
After https://github.com/kiegroup/kogito-runtimes/pull/1643, Kogito
needs both `quarkus-resteasy` and `quarkus-resteasy-jackson` to be
able to build with tests - tests invoke REST endpoint.
The Kogito PR was merged in Kogito `1.13.0.Final` (in Quarkus Platform
`2.5.0.CR1`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radtriste radtriste radtriste approved these changes

@danielezonca danielezonca danielezonca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evacchi @kie-ci @danielezonca @radtriste