Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node duration metric to monitoring addon #3483

Closed
fjtirado opened this issue Apr 23, 2024 · 4 comments · Fixed by #3485
Closed

Add node duration metric to monitoring addon #3483

fjtirado opened this issue Apr 23, 2024 · 4 comments · Fixed by #3485
Assignees

Comments

@fjtirado
Copy link
Contributor

fjtirado commented Apr 23, 2024

Description

It would be interesting to track the duration of certain nodes, as we are tracking process instances duration and all work items duration

Implementation ideas

In BPMN and SWF parsers, add a metadata key called "Metric" to those nodes that it will be interesting to track duration for.
In monitoring addon, add a new Distributionsummary object called ""kogito_node_instance_duration_seconds" which will record duration for those nodes flagged with the metadata key.

@fjtirado
Copy link
Contributor Author

@elguardian Should I change the BPMN parser to add the metric metadata to certain nodes (in that case we need to dicuss which ones) or do you prefer to do that with a follow up issue?

@elguardian
Copy link
Contributor

there is no need to change the parsec... the editor has already a metadata section. so you just need to take that into account in the runtime

@fjtirado
Copy link
Contributor Author

fjtirado commented Apr 24, 2024

there is no need to change the parsec... the editor has already a metadata section. so you just need to take that into account in the runtime

Sure, I mean, add to the parser logic a call to nodefactory.metadata ("metric", "node name as it should appear in metric tag") for those nodes which duration should be recorded

@elguardian
Copy link
Contributor

the metadata is added automatically in the visitor. you don't need to do anything special

fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Apr 24, 2024
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Apr 24, 2024
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Apr 24, 2024
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this issue Apr 24, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎯 Done in 🦉 KIE Podling Board Apr 25, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants